You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/28 19:20:56 UTC

[GitHub] srkukarni commented on a change in pull request #2875: Hooked up secrets function api with secret function implementations

srkukarni commented on a change in pull request #2875: Hooked up secrets function api with secret function implementations
URL: https://github.com/apache/pulsar/pull/2875#discussion_r228761197
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeUtils.java
 ##########
 @@ -49,6 +50,8 @@
                                            Integer grpcPort,
                                            Long expectedHealthCheckInterval,
                                            String logConfigFile,
+                                           String secretsProviderClassName,
 
 Review comment:
   I've added more comments.
   I dont think having classname in config is a good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services