You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Robert Surówka (Created JIRA)" <ji...@apache.org> on 2011/10/05 23:40:31 UTC

[jira] [Created] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------

                 Key: HIVE-2487
                 URL: https://issues.apache.org/jira/browse/HIVE-2487
             Project: Hive
          Issue Type: Bug
            Reporter: Robert Surówka
            Assignee: Robert Surówka
            Priority: Trivial




--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "He Yongqiang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-2487:
-------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

committed, thanks Robert!
                
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch, HIVE-2487.1.patch, HIVE-2487.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "Robert Surówka (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Surówka updated HIVE-2487:
---------------------------------

    Status: Patch Available  (was: Open)
    
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "Robert Surówka (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121526#comment-13121526 ] 

Robert Surówka commented on HIVE-2487:
--------------------------------------

Diff request at https://reviews.apache.org/r/2234/diff/#index_header
                
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch, HIVE-2487.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130110#comment-13130110 ] 

Hudson commented on HIVE-2487:
------------------------------

Integrated in Hive-trunk-h0.21 #1019 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1019/])
    HIVE-2487: Bug from HIVE-2446, the code that calls client stats publishers should be inside the while loop (Robert Surówka via He Yongqiang)

heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185767
Files : 
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java

                
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch, HIVE-2487.1.patch, HIVE-2487.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "Robert Surówka (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Surówka updated HIVE-2487:
---------------------------------

    Attachment: HIVE-2487.2.patch

See updated diff request at https://reviews.apache.org/r/2234/diff/2/ (added runtime exception handling)
                
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch, HIVE-2487.1.patch, HIVE-2487.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "Ning Zhang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130873#comment-13130873 ] 

Ning Zhang commented on HIVE-2487:
----------------------------------

Yongqiang, it seems you have committed this patch? Can you close this JIRA if so? 
                
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch, HIVE-2487.1.patch, HIVE-2487.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "Robert Surówka (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Surówka updated HIVE-2487:
---------------------------------

    Attachment: HIVE-2487.1.patch
    
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "Robert Surówka (Updated JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Surówka updated HIVE-2487:
---------------------------------

    Attachment: HIVE-2487.1.patch

current version (previous was diffed from not most up to date branch)
                
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch, HIVE-2487.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (HIVE-2487) Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop

Posted by "He Yongqiang (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126895#comment-13126895 ] 

He Yongqiang commented on HIVE-2487:
------------------------------------

+1, will commit after tests pass
                
> Bug from HIVE-2446, the code that calls client stats publishers run() methods is in wrong place, should be in the same method but inside of while (!rj.isComplete()) {} loop
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2487
>                 URL: https://issues.apache.org/jira/browse/HIVE-2487
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Trivial
>         Attachments: HIVE-2487.1.patch, HIVE-2487.1.patch, HIVE-2487.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira