You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by petevg <gi...@git.apache.org> on 2016/06/16 19:49:58 UTC
[GitHub] bigtop pull request #122: BIGTOP-2478: Zookeeper does not have any smoke tes...
GitHub user petevg opened a pull request:
https://github.com/apache/bigtop/pull/122
BIGTOP-2478: Zookeeper does not have any smoke tests
These tests are very basic for now. We just run "zkServer.sh status" and
verify that the output is reasonable.
More complex tests are blocked by either a) needing multiple Zookeeper
nodes (doesn't really make sense for a smoke test), or b) needing to
have Zookeeper REST spun up, which Bigtop does not currently do.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/juju-solutions/bigtop BIGTOP-2478
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bigtop/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 0c507c05e3fd8dd3fc9d249823eac4bf66633e5c
Author: Pete Vander Giessen <pe...@gmail.com>
Date: 2016-06-16T19:46:50Z
BIGTOP-2478: Zookeeper does not have any smoke tests
These tests are very basic for now. We just run "zkServer.sh status" and
verify that the output is reasonable.
More complex tests are blocked by either a) needing multiple Zookeeper
nodes (doesn't really make sense for a smoke test), or b) needing to
have Zookeeper REST spun up, which Bigtop does not currently do.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #122: BIGTOP-2478: Zookeeper does not have any smoke tes...
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/122#discussion_r67440497
--- Diff: bigtop-tests/smoke-tests/zookeeper/TestZookeeper.groovy ---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.junit.BeforeClass
+import org.junit.AfterClass
+
+import org.apache.bigtop.itest.shell.Shell
+import static org.junit.Assert.assertTrue
+import org.junit.Test
+import org.apache.commons.logging.LogFactory
+import org.apache.commons.logging.Log
+
+import static org.apache.bigtop.itest.LogErrorsUtils.logError
+
+class TestSpark {
--- End diff --
You probably don't want it to be called TestSpar, do you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #122: BIGTOP-2478: Zookeeper does not have any smoke tests
Posted by petevg <gi...@git.apache.org>.
Github user petevg commented on the issue:
https://github.com/apache/bigtop/pull/122
@rvs: Whoops. Fixed the name. Thank you :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop issue #122: BIGTOP-2478: Zookeeper does not have any smoke tests
Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on the issue:
https://github.com/apache/bigtop/pull/122
This looks good as a very, very basic ZK test. See the small nit I had tho.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bigtop pull request #122: BIGTOP-2478: Zookeeper does not have any smoke tes...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bigtop/pull/122
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---