You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by we...@apache.org on 2018/05/24 03:42:32 UTC
spark git commit: [MINOR][CORE] Cleanup unused vals in
`DAGScheduler.handleTaskCompletion`
Repository: spark
Updated Branches:
refs/heads/master 486ecc680 -> e108f84f5
[MINOR][CORE] Cleanup unused vals in `DAGScheduler.handleTaskCompletion`
## What changes were proposed in this pull request?
Cleanup unused vals in `DAGScheduler.handleTaskCompletion` to reduce the code complexity slightly.
## How was this patch tested?
Existing test cases.
Author: Xingbo Jiang <xi...@databricks.com>
Closes #21406 from jiangxb1987/handleTaskCompletion.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e108f84f
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e108f84f
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e108f84f
Branch: refs/heads/master
Commit: e108f84f5cd562f070872651bdcf6c02e80dd585
Parents: 486ecc6
Author: Xingbo Jiang <xi...@databricks.com>
Authored: Thu May 24 11:42:25 2018 +0800
Committer: Wenchen Fan <we...@databricks.com>
Committed: Thu May 24 11:42:25 2018 +0800
----------------------------------------------------------------------
.../main/scala/org/apache/spark/scheduler/DAGScheduler.scala | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/e108f84f/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
index ea7bfd7..041eade 100644
--- a/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
+++ b/core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
@@ -1167,9 +1167,7 @@ class DAGScheduler(
*/
private[scheduler] def handleTaskCompletion(event: CompletionEvent) {
val task = event.task
- val taskId = event.taskInfo.id
val stageId = task.stageId
- val taskType = Utils.getFormattedClassName(task)
outputCommitCoordinator.taskCompleted(
stageId,
@@ -1323,7 +1321,7 @@ class DAGScheduler(
"tasks in ShuffleMapStages.")
}
- case FetchFailed(bmAddress, shuffleId, mapId, reduceId, failureMessage) =>
+ case FetchFailed(bmAddress, shuffleId, mapId, _, failureMessage) =>
val failedStage = stageIdToStage(task.stageId)
val mapStage = shuffleIdToMapStage(shuffleId)
@@ -1411,7 +1409,7 @@ class DAGScheduler(
}
}
- case commitDenied: TaskCommitDenied =>
+ case _: TaskCommitDenied =>
// Do nothing here, left up to the TaskScheduler to decide how to handle denied commits
case _: ExceptionFailure | _: TaskKilled =>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org