You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/20 13:57:11 UTC

[GitHub] [incubator-seatunnel] wuchunfu commented on a diff in pull request #3985: [Hotfix][E2E][Clickhouse] Fix the bug of clickhouse e2e case

wuchunfu commented on code in PR #3985:
URL: https://github.com/apache/incubator-seatunnel/pull/3985#discussion_r1082568164


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-clickhouse-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/ClickhouseSinkCDCChangelogIT.java:
##########
@@ -180,12 +186,15 @@ private void checkSinkTableRows() throws SQLException {
                 Arrays.asList(1L, "A_1", 100),
                 Arrays.asList(3L, "C", 100))
             .collect(Collectors.toSet());
-        Assertions.assertIterableEquals(expected, actual);
+        if (!Arrays.equals(expected.toArray(), expected.toArray())) {

Review Comment:
   There seems to be a problem with the parameters here. It should be `if (! Arrays. equals (expected. toArray(), actual)) {`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org