You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/10 08:53:47 UTC

[GitHub] [flink] hlteoh37 opened a new pull request, #21002: [FLINK-29395][Connector/Kinesis] Handle empty deaggregated records in…

hlteoh37 opened a new pull request, #21002:
URL: https://github.com/apache/flink/pull/21002

   …FanOutRecordPublisher
   
   ## What is the purpose of the change
   
   Cherry-pick of https://github.com/apache/flink/pull/20945/files
   
   The consumer fails when three conditions are met:
   1. Kinesis EFO record publisher uses an AT_TIMESTAMP starting position.
   2. The first record batch is not empty.
   3. The deaggregated record batch is empty.
   
   This can happen when the user writes aggregated records into their Kinesis stream whilst specifying the explicitHashKey for every single user record. When resharding occurs, there is a possibility that records within the same aggregated batch fall into two different shards, since they have different explicit hash keys. When this happens, the deaggregated records are dropped. (We need to do this in Kinesis Consumer so we do not process duplicate records. See https://github.com/awslabs/kinesis-aggregation/issues/11)
   
   If all deaggregated records are dropped, the consumer receives an empty deaggregated record batch even though the record batch is not empty.
   
   ## Brief change log
   
   This is fixed by returning the AT_TIMESTAMP starting position when receiving an AT_TIMESTAMP sentinel sequence number.
   
   ## Verifying this change
   - Unit tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] flinkbot commented on pull request #21002: [FLINK-29395][Connector/Kinesis] Handle empty deaggregated records in…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21002:
URL: https://github.com/apache/flink/pull/21002#issuecomment-1272997380

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "39d1566f6b77a2d7e8677bca9abd1fc28d3d7b32",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "39d1566f6b77a2d7e8677bca9abd1fc28d3d7b32",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 39d1566f6b77a2d7e8677bca9abd1fc28d3d7b32 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink] dannycranmer merged pull request #21002: [FLINK-29395][Connector/Kinesis] Handle empty deaggregated records in…

Posted by GitBox <gi...@apache.org>.
dannycranmer merged PR #21002:
URL: https://github.com/apache/flink/pull/21002


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org