You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Marc Slemko <ma...@znep.com> on 1997/06/29 07:31:12 UTC
[PATCH] LESS_SLACK_JACK/NO_SLACK
Gets rid of LESS_SLACK_JACK, but implements NO_SLACK with a define instead
of a function.
Or I'd be happy just trashing the LESS_SLACK_JACK changes completely.
Either way...
Index: conf.h
===================================================================
RCS file: /export/home/cvs/apache/src/conf.h,v
retrieving revision 1.106
diff -u -r1.106 conf.h
--- conf.h 1997/06/29 01:58:32 1.106
+++ conf.h 1997/06/29 05:22:51
@@ -550,7 +550,7 @@
#define O_RDWR _O_RDWR
#define SIGPIPE 17
/* Seems Windows is not a subgenius */
-#define LESS_SLACK_JACK
+#define NO_SLACK
#include <stddef.h>
/* Unknown system - Edit these to match */
#else
Index: httpd.h
===================================================================
RCS file: /export/home/cvs/apache/src/httpd.h,v
retrieving revision 1.118
diff -u -r1.118 httpd.h
--- httpd.h 1997/06/28 23:57:57 1.118
+++ httpd.h 1997/06/29 05:22:54
@@ -755,7 +755,7 @@
* never fails. If the high line was requested and it fails it will also try
* the low line.
*/
-#ifdef LESS_SLACK_JACK
+#ifdef NO_SLACK
#define ap_slack(fd,line) (fd)
#else
int ap_slack (int fd, int line);
Index: util.c
===================================================================
RCS file: /export/home/cvs/apache/src/util.c,v
retrieving revision 1.57
diff -u -r1.57 util.c
--- util.c 1997/06/28 22:39:23 1.57
+++ util.c 1997/06/29 05:23:05
@@ -1335,10 +1335,10 @@
}
#endif
-#ifndef LESS_SLACK_JACK
+#ifndef NO_SLACK
int ap_slack (int fd, int line)
{
-#if !defined(F_DUPFD) || defined(NO_SLACK)
+#if !defined(F_DUPFD)
return fd;
#else
int new_fd;
@@ -1364,4 +1364,4 @@
return new_fd;
#endif
}
-#endif /* LESS_SLACK_JACK */
+#endif /* NO_SLACK */
Re: [PATCH] LESS_SLACK_JACK/NO_SLACK
Posted by Dean Gaudet <dg...@arctic.org>.
In the 1.2 code the slack things are not in the request code path, so
performance isn't important at all. It's conceivable that in the future
performance may be an issue. But I doubt it. So it don't matter to me
which way it's fixed...
Dean
On Sat, 28 Jun 1997, Marc Slemko wrote:
> Gets rid of LESS_SLACK_JACK, but implements NO_SLACK with a define instead
> of a function.
>
> Or I'd be happy just trashing the LESS_SLACK_JACK changes completely.
> Either way...
>
> Index: conf.h
> ===================================================================
> RCS file: /export/home/cvs/apache/src/conf.h,v
> retrieving revision 1.106
> diff -u -r1.106 conf.h
> --- conf.h 1997/06/29 01:58:32 1.106
> +++ conf.h 1997/06/29 05:22:51
> @@ -550,7 +550,7 @@
> #define O_RDWR _O_RDWR
> #define SIGPIPE 17
> /* Seems Windows is not a subgenius */
> -#define LESS_SLACK_JACK
> +#define NO_SLACK
> #include <stddef.h>
> /* Unknown system - Edit these to match */
> #else
> Index: httpd.h
> ===================================================================
> RCS file: /export/home/cvs/apache/src/httpd.h,v
> retrieving revision 1.118
> diff -u -r1.118 httpd.h
> --- httpd.h 1997/06/28 23:57:57 1.118
> +++ httpd.h 1997/06/29 05:22:54
> @@ -755,7 +755,7 @@
> * never fails. If the high line was requested and it fails it will also try
> * the low line.
> */
> -#ifdef LESS_SLACK_JACK
> +#ifdef NO_SLACK
> #define ap_slack(fd,line) (fd)
> #else
> int ap_slack (int fd, int line);
> Index: util.c
> ===================================================================
> RCS file: /export/home/cvs/apache/src/util.c,v
> retrieving revision 1.57
> diff -u -r1.57 util.c
> --- util.c 1997/06/28 22:39:23 1.57
> +++ util.c 1997/06/29 05:23:05
> @@ -1335,10 +1335,10 @@
> }
> #endif
>
> -#ifndef LESS_SLACK_JACK
> +#ifndef NO_SLACK
> int ap_slack (int fd, int line)
> {
> -#if !defined(F_DUPFD) || defined(NO_SLACK)
> +#if !defined(F_DUPFD)
> return fd;
> #else
> int new_fd;
> @@ -1364,4 +1364,4 @@
> return new_fd;
> #endif
> }
> -#endif /* LESS_SLACK_JACK */
> +#endif /* NO_SLACK */
>
>