You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2026/10/12 20:54:03 UTC

[PR] fix(samples): align basic sample with dev-dependencies [superset-kubernetes-operator]

villebro opened a new pull request, #429:
URL: https://github.com/apache/superset-kubernetes-operator/pull/429

## Summary

The basic sample (`config/samples/superset_v1alpha1_superset.yaml`) cannot run against the dev backing services in `config/samples/dev-dependencies.yaml`. It uses the lean `6.1.0` image, which ships no database drivers, so the migrate task fails with `ModuleNotFoundError: No module named 'psycopg2'`. It also sets no Valkey password, while the dev Valkey requires `superset`. Separately, the development setup guide hand-builds a third Postgres/Valkey variant (passwordless Valkey, `postgres:16`). This PR makes `dev-dependencies.yaml` the single source of truth for local dev and adds a unit test so the samples cannot drift from it again.

## Details

- **Basic sample:** `image.tag: 6.1.0-dev` (includes `psycopg2`) and `valkey.password: superset`. The header now points at `dev-dependencies.yaml` and explains why the `-dev` variant is needed.
- **`dev-dependencies.yaml`:** the header now says it backs both Development-mode samples.
- **`docs/contributing/development-setup.md`:** steps 2–3 are replaced by `kubectl apply -f config/samples/dev-dependencies.yaml`, and the following steps are renumbered. No docs link to these anchors.
- **`test/samples/samples_test.go`** (runs under `make test-unit`):
- Finds every `superset_v1alpha1_*.yaml` sample with `environment: Development`.
- Identifies the PostgreSQL and Valkey Deployments in `dev-dependencies.yaml` from their configuration, and resolves each host from the Service that selects it.
- Asserts each sample's metastore (URI or structured fields) and Valkey host, port, credentials and database match, and that the image tag is a `-dev` variant.
- Against the current `main` sample it fails on both the lean image tag and the missing Valkey password.

Verified on Kind 0.33 (`kindest/node:v1.37.0`) with the operator built from `main` @ 27da539: `dev-dependencies.yaml` plus the updated basic sample reach `Running` / `Available` in about 4 minutes. `/health` returns `OK` and `/login/` returns 200. `make lint-go` and `make lint-md` pass.

Not changed here: the README, `docs/getting-started.md`, `docs/index.md` and some user-guide snippets also pair the lean `6.1.0` image with a `postgresql+psycopg2` URI. `configuration.md` already documents that lean images ship without drivers, so I've left those for a separate discussion. The `0.3` branch has the same basic sample, if a backport is wanted.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(samples): align basic sample with dev-dependencies [superset-kubernetes-operator]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #429:
URL: https://github.com/apache/superset-kubernetes-operator/pull/429#issuecomment-6132515747

   ## [Codecov](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/429?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 93.18%. Comparing base ([`27da539`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/27da53931e3360594401579da1819092974fedef?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8f1071a`](https://app.codecov.io/gh/apache/superset-kubernetes-operator/commit/8f1071af49f42c68914e6ad16e66da4ed365c342?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on main.
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset-kubernetes-operator/pull/429?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(samples): align basic sample with dev-dependencies [superset-kubernetes-operator]

Posted by "villebro (via GitHub)" <gi...@apache.org>.

villebro merged PR #429:
URL: https://github.com/apache/superset-kubernetes-operator/pull/429


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org