You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/06 13:26:29 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4453: Provide cleanup option to force deleting a project

ravening opened a new pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453


   ## Description
   <!--- Describe your changes in detail -->
   Provide an option to user which when selected
   deletes all the resources in the project.
   If not selected then the project is not deleted if
   all the resources are not yet cleaned up
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [X] Enhancement (improves an existing feature and functionality)
   
   ## Screenshots (if appropriate):
   
   ![Screenshot 2020-11-06 at 14 25 38](https://user-images.githubusercontent.com/10645273/98371127-f45fa400-203b-11eb-9d88-0e5722836156.png)
   ] 
   
   
   
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening edited a comment on pull request #4453: Provide cleanup option to force deleting a project

Posted by GitBox <gi...@apache.org>.
ravening edited a comment on pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453#issuecomment-767478160


   @weizhouapache  created new pr https://github.com/apache/cloudstack/pull/4617


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening closed pull request #4453: Provide cleanup option to force deleting a project

Posted by GitBox <gi...@apache.org>.
ravening closed pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4453: Provide cleanup option to force deleting a project

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453#issuecomment-766910722


   @ravening can you resolve the conflicts, and make primate ui change ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] DaanHoogland commented on pull request #4453: Provide cleanup option to force deleting a project

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453#issuecomment-728822379


   code looks ok, but needs tests and primate UI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4453: Provide cleanup option to force deleting a project

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453#issuecomment-767478160


   @ustcweizhou created new pr https://github.com/apache/cloudstack/pull/4617


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] weizhouapache commented on pull request #4453: Provide cleanup option to force deleting a project

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453#issuecomment-766910722


   @ravening can you resolve the conflicts, and make primate ui change ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] ravening commented on pull request #4453: Provide cleanup option to force deleting a project

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4453:
URL: https://github.com/apache/cloudstack/pull/4453#issuecomment-730415346


   > code looks ok, but needs tests and primate UI
   
   @DaanHoogland I have already created pr for ui changes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org