You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "yardenshoham (via GitHub)" <gi...@apache.org> on 2025/01/06 09:06:45 UTC
[PR] docs: Add troubleshooting option for openid-connect [apisix]
yardenshoham opened a new pull request, #11892:
URL: https://github.com/apache/apisix/pull/11892
This solved my issue when nothing else did.
References https://github.com/apache/apisix/issues/11711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #11892:
URL: https://github.com/apache/apisix/pull/11892#issuecomment-2592106212
I think it's better to separate this change from https://github.com/apache/apisix/pull/11889 as the update requires a modification to the plugin schema and test case (albeit simple).
Will wait till #11889 is merged and proceed with this change. Thanks for your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 closed pull request #11892: docs: add troubleshooting option for openid-connect
URL: https://github.com/apache/apisix/pull/11892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #11892:
URL: https://github.com/apache/apisix/pull/11892#issuecomment-2591727465
Ok I will evaluate and update accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on code in PR #11892:
URL: https://github.com/apache/apisix/pull/11892#discussion_r1904899781
##########
docs/en/latest/plugins/openid-connect.md:
##########
@@ -275,6 +275,21 @@ upstream sent too big header while reading response header from upstream
If so, try adjusting `proxy_buffers`, `proxy_buffer_size`, and `proxy_busy_buffers_size` to larger values.
+Another option is to set the `session_content` attribute:
+
+```yaml
+openid-connect:
+ ...
+ bearer_only: false
+ # this comes from https://github.com/zmartzone/lua-resty-openidc, if this is missing, all information will be stored in the session. This
+ # causes the cookies to be too large and the request to fail. We have control over id_token, user, enc_id_token, and access_token.
+ # We currently include only access_token in the session. If this gets too big we can remove it as well.
Review Comment:
Could you simplify the comment to
```text
# use session_contents option to configure which information among id_token, user, enc_id_token, and access_token, get stored.
```
and add the same doc update to the Chinese doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11892:
URL: https://github.com/apache/apisix/pull/11892#issuecomment-2753856374
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on PR #11892:
URL: https://github.com/apache/apisix/pull/11892#issuecomment-2812193571
I'm including this info in the other doc PR now, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "kayx23 (via GitHub)" <gi...@apache.org>.
kayx23 commented on code in PR #11892:
URL: https://github.com/apache/apisix/pull/11892#discussion_r1904900754
##########
docs/en/latest/plugins/openid-connect.md:
##########
@@ -275,6 +275,21 @@ upstream sent too big header while reading response header from upstream
If so, try adjusting `proxy_buffers`, `proxy_buffer_size`, and `proxy_busy_buffers_size` to larger values.
+Another option is to set the `session_content` attribute:
+
+```yaml
+openid-connect:
+ ...
+ bearer_only: false
+ # this comes from https://github.com/zmartzone/lua-resty-openidc, if this is missing, all information will be stored in the session. This
+ # causes the cookies to be too large and the request to fail. We have control over id_token, user, enc_id_token, and access_token.
+ # We currently include only access_token in the session. If this gets too big we can remove it as well.
+ session_contents:
+ access_token: true
Review Comment:
Technically this is an attribute that was previously not explicitly exposed, so should be also be added to attribute section of the doc; as well as to the plugin schema in the source code (relevant tests need to be updated as well) 💠cc: @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs: add troubleshooting option for openid-connect [apisix]
Posted by "yardenshoham (via GitHub)" <gi...@apache.org>.
yardenshoham commented on PR #11892:
URL: https://github.com/apache/apisix/pull/11892#issuecomment-2574669959
Maybe you could take over and do everything in https://github.com/apache/apisix/pull/11889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org