You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by wenfengwang <gi...@git.apache.org> on 2017/04/19 16:58:23 UTC
[GitHub] incubator-rocketmq-externals pull request #13: RocketMQ Go SDK implementatio...
GitHub user wenfengwang opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/13
RocketMQ Go SDK implementation
Hi, some works have not yet complete, please not merge the PR. Welcome any guys provide any reviews, suggestions, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wenfengwang/incubator-rocketmq-externals master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq-externals/pull/13.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13
----
commit ea595dbf4e0961bc6f84177eeaf8f224e95ab672
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-12T16:07:10Z
first commit go sdk code
commit 5d53890289f14be26058fe1720f131f717710d5f
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-13T02:07:54Z
go gmt & modify directory
commit 0f49653a337613382139237a01381fe36545ad25
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:00:58Z
add model/message
commit 4a3f1207e03d06656b3daec360c13f987384c112
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:08:22Z
add pull_result
commit bdc08a3fbe66b0e39d932c625f2c105a7b0243b0
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:09:31Z
add send_result
commit 578bb2e7fed0918b5a9bb584846d5892c0467f77
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:11:06Z
modify header reciver name
commit c16ec96cdd8f0a9c21e53d17d3a60cec820bbbfa
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:25:17Z
add client config
commit fbf709ec7fe5e6426b682395430f9c931072f3f9
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:30:46Z
add query_result & topic
commit a63e5808e2fe412c47202dbebabf042b4ccd3f6c
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:35:41Z
add file to service directory
commit 2f08bec3519a57b5fd479ea129e0ef6f01c7f03b
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:38:41Z
add file to remoting directory
commit 18c18283e6a7a7d9fe71fa37644aca8c9c36c8af
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:39:01Z
some tiny update
commit 35e4fac0cf55579cfc2315d3a2f22fcf3e6865e5
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:42:26Z
go fmt
commit a509588c5a09b2e2dd5a70f067ec9f8cf4284120
Author: wangwenfeng <sx...@gmail.com>
Date: 2017-04-19T16:46:42Z
update README.md for referenced reops
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...
Posted by wenfengwang <gi...@git.apache.org>.
Github user wenfengwang commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/13
I hava fix Chinese docs's translation, and solved the cycle dependence problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals pull request #13: [ROCKETMQ-182] RocketMQ Go SD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq-externals/pull/13
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/13
Cool, please let us know when this PR can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals pull request #13: [ROCKETMQ-182] RocketMQ Go SD...
Posted by StyleTang <gi...@git.apache.org>.
Github user StyleTang commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/13#discussion_r112835033
--- Diff: rocketmq-go/model/response_code.go ---
@@ -0,0 +1,67 @@
+package model
+
+const (
+ // success
+ Success = 0
+ // happened unknow error exception
+ SystemError = 1
+ // system busy
+ SystemBusy = 2
+ // unsupport request code
+ RequestCodeNotSupported = 3
+ // transaction failed, because of add db failed
+ TransactionFailed = 4
+ // Broker flush disk timeout
+ FlushDiskTimeout = 10
+ // Broker slave unavailable, just for sync double write
+ SlaveNotAvailable = 11
+ // Broker write slave timeout, just for sync double write
+ FlushSlaveTimeout = 12
+ // Broker illegal message
+ MessageIllegal = 13
+ // Broker, Namesrv not available\uff0cmaybe service is closing or incorrect permission
+ ServiceNotAvailable = 14
+ // Broker, Namesrv unsupport version
+ VersionNOtSupported = 15
+ // Broker, Namesrv no permission for operation with send/receive or other
+ NoPermission = 16
+ // Broker, topic not exist
+ TopicNotExist = 17
+ // Broker, topic already exist
+ TopicExistAlready = 18
+ // Broker message not found when pull
+ PullNotFound = 19
+ // Broker retry immediately, maybe msg was filtered or incorrect notification TODO confirm annotation
+ PullRetryImmediately = 20
+ // Broker pull offset moved, because of too big or to small TODO confirm annotation
+ PullOffsetMoved = 21
+ // Broker query not found
+ QueryNotFound = 22
+ // Broker parse subscription failed
+ SubscriptionParseFailed = 23
+ // Broker subscription relationship not existed
+ SubscriptionNotExist = 24
+ // Broker subscription relationship not latest
+ SubscriptionNotLatest = 25
+ // Broker subscription group not exist
+ SubscriptionGroupNotExist = 26
+ // Producer transaction should commit
+ TransactionShouldCommit = 200
+ // Producer transaction should rollback
+ TransactionShouldRollback = 201
+ // Producer transaction status unknow
+ TransactionStatusUnknow = 202
+ // Producer ProducerGroup\u9519\u8bef
--- End diff --
\u9519\u8bef->error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...
Posted by wenfengwang <gi...@git.apache.org>.
Github user wenfengwang commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/13
@zhouxinyu Can you point out the Chinese docs in this PR, I didn't find it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals pull request #13: [ROCKETMQ-182] RocketMQ Go SD...
Posted by StyleTang <gi...@git.apache.org>.
Github user StyleTang commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/13#discussion_r112834996
--- Diff: rocketmq-go/hook/rpchook.go ---
@@ -14,4 +14,10 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package header
+
+package hook
+
+type RPCHook interface { // TODO solve cycle dependence
--- End diff --
this will cause compile error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...
Posted by StyleTang <gi...@git.apache.org>.
Github user StyleTang commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/13
Well done. @wenfengwang
There are still some minor problems here, but I think we can merge it first.
I will implement the package of remoting base on it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...
Posted by wenfengwang <gi...@git.apache.org>.
Github user wenfengwang commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/13
@zhouxinyu The PR can be merged, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/13
@wenfengwang cool, please polish request_code.go before we can merge this PR, remove or translate the Chinese docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #13: [ROCKETMQ-182] RocketMQ Go SDK imple...
Posted by wenfengwang <gi...@git.apache.org>.
Github user wenfengwang commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/13
@zhouxinyu Hi yukon, the PR can be merged, which mainly include:
*Basic Model: message, (pull/query/send)_result, topic, header, config, constants
*Remoting: Not yet completed
please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---