You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "AntonRoskvist (via GitHub)" <gi...@apache.org> on 2026/06/17 08:37:41 UTC
[PR] ARTEMIS-6119 Stomp subscriber cannot receive compressed messages [artemis]
AntonRoskvist opened a new pull request, #6522:
URL: https://github.com/apache/artemis/pull/6522
If a Stomp subscriber tries to receive a message that has been compressed by a Core client it will fail (because no inflation of the compressed body takes place)
This change would use the Core message `getDataBuffer()` to manage this along with handling of "regular" large messages in the `VersionedStompFrameHandler` (basically moving the Large body read step from there to use the existing one on the Core message)
All tests pass, though I have limited experience with the Stomp protocol so if anything seems off just let me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6119 Stomp subscriber cannot receive compressed messages [artemis]
Posted by "AntonRoskvist (via GitHub)" <gi...@apache.org>.
AntonRoskvist commented on code in PR #6522:
URL: https://github.com/apache/artemis/pull/6522#discussion_r3433636835
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompTest.java:
##########
@@ -338,6 +338,33 @@ public void sendMQTTReceiveSTOMP() throws Exception {
}
+ @Test
+ public void testReceiveCompressedMessage() throws Exception {
+ String DATA = RandomUtil.randomAlphaNumericString(1024 * 1024);
Review Comment:
Thanks, yes I originally had the test produce two messages, one with the current string and the other just doing `String DATA2 = "a".repeat(1024 * 1024);` to test both branches in the `VersionedStompFrameHandler`.
I removed the second one when I realized I could just remove the `populateFrameBodyFromLargeMessage` method all together. Keeping the one as a large message on the broker made the most sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6119 Stomp subscriber cannot receive compressed messages [artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic merged PR #6522:
URL: https://github.com/apache/artemis/pull/6522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6119 Stomp subscriber cannot receive compressed messages [artemis]
Posted by "AntonRoskvist (via GitHub)" <gi...@apache.org>.
AntonRoskvist commented on code in PR #6522:
URL: https://github.com/apache/artemis/pull/6522#discussion_r3433636835
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompTest.java:
##########
@@ -338,6 +338,33 @@ public void sendMQTTReceiveSTOMP() throws Exception {
}
+ @Test
+ public void testReceiveCompressedMessage() throws Exception {
+ String DATA = RandomUtil.randomAlphaNumericString(1024 * 1024);
Review Comment:
Thanks, yes I originally had the test produce two messages, one with the current string and the other just doing `String DATA2 = "a".repeat(1024 * 1024);` to test both branches in the ` VersionedStompFrameHandler`.
I removed the second one when I realized I could just remove the `populateFrameBodyFromLargeMessage` method all together. Keeping the one as a large message on the broker made the most sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org
Re: [PR] ARTEMIS-6119 Stomp subscriber cannot receive compressed messages [artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #6522:
URL: https://github.com/apache/artemis/pull/6522#discussion_r3429370799
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompTest.java:
##########
@@ -338,6 +338,33 @@ public void sendMQTTReceiveSTOMP() throws Exception {
}
+ @Test
+ public void testReceiveCompressedMessage() throws Exception {
+ String DATA = RandomUtil.randomAlphaNumericString(1024 * 1024);
Review Comment:
this little detail here was great.. the test generated a unique string that's not very compressed. I tried using a simple "LARGE".repeat(200 * 1024) and the large message file was not there.. and I figured it out you used this to make sure it was kept as a file.. nice test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org