You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/06/20 10:44:57 UTC

[GitHub] [incubator-devlake] abeizn opened a new pull request, #2267: feat: multi-conn for tapd and update migrationscripts

abeizn opened a new pull request, #2267:
URL: https://github.com/apache/incubator-devlake/pull/2267

   # Summary
   
   update api/connection to load and save through db not .env
   and update migrationscripts
   
   ### Does this close any open issues?
   related to #2262 
   
   ### Screenshots
   ![image](https://user-images.githubusercontent.com/101256042/174585006-5529aa20-00e0-4413-a4fe-accb9f373d18.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] abeizn merged pull request #2267: feat: multi-conn for tapd and update migrationscripts

Posted by GitBox <gi...@apache.org>.
abeizn merged PR #2267:
URL: https://github.com/apache/incubator-devlake/pull/2267


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #2267: feat: multi-conn for tapd and update migrationscripts

Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #2267:
URL: https://github.com/apache/incubator-devlake/pull/2267#discussion_r902068884


##########
plugins/tapd/models/migrationscripts/init_schema.go:
##########
@@ -19,6 +19,7 @@ package migrationscripts
 
 import (
 	"context"
+
 	"github.com/apache/incubator-devlake/plugins/tapd/models/migrationscripts/archived"
 	"gorm.io/gorm"
 )

Review Comment:
   we need to drop tables first



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org