You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Max Starets <ma...@oracle.com> on 2010/02/04 16:57:20 UTC

[Trinidad] JSF2: Facelet tag metadata 

Hello Everyone,

Does anybody have any objections to enhancing Trinidad maven plugins to 
write out Facelet tag metadata
in taglib xml (see https://issues.apache.org/jira/browse/TRINIDAD-1707)?

I have the implementation ready.

Thanks,
Max

Re: [Trinidad] JSF2: Facelet tag metadata

Posted by Matthias Wessendorf <ma...@apache.org>.
:-) I am not sure if that makes sense.
I felt it did, when I added the first check for JSF2.

I didn't want to mess around w/ trunk for the "first" Trindiad2 added
plugin "features"

Does that make sense?

-Matthias

On Thu, Feb 4, 2010 at 9:42 PM, Max Starets <ma...@oracle.com> wrote:
> Matthias,
>
> I was fooled by the fact that it was a '2.0.0.x' branch. I have no problem
> adding a check.
>
> Max
>
> Matthias Wessendorf wrote:
>
> Well,
>
> there is only one version of the plugin.
> Trunk covers JSF 1.1 and 1.2
>
> The goal is to continue that as well. The branch was just created to
> have the (experimental) JSF2 development
> not mixed with those changes on trunk.
>
> Do you really feel a need to introduce again a 2-way plugin ?
> a) 1.2 and 1.1
> b) 2.0
>
> For some of the XSL I already added a check for JSF2
>
> -Matthias
>
> On Thu, Feb 4, 2010 at 9:22 PM, Max Starets <ma...@oracle.com> wrote:
>
>
> Matthias,
>
> What do you mean? The change is going only to the 2.0.x branch.
> It will only be used with JSF 2.0+.
>
> Max
>
> Matthias Wessendorf wrote:
>
> Hello Max,
>
> shouldn't we check for the jsfVersion, for the metadata ?
>
> -Matthias
>
> On Thu, Feb 4, 2010 at 6:08 PM, Matthias Wessendorf <ma...@apache.org>
> wrote:
>
>
> +1 - yeah would be nice as the plugins cover already faces cfg part for
> that.
>
> So, feel free to upload the patch, since the impl is done :-)
>
> -M
>
> On Thu, Feb 4, 2010 at 5:57 PM, Blake Sullivan
> <bl...@oracle.com> wrote:
>
>
> +1
>
> -- Blake Sullivan
>
> Max Starets said the following On 2/4/2010 7:57 AM PT:
>
>
> Hello Everyone,
>
> Does anybody have any objections to enhancing Trinidad maven plugins to
> write out Facelet tag metadata
> in taglib xml (see https://issues.apache.org/jira/browse/TRINIDAD-1707)?
>
> I have the implementation ready.
>
> Thanks,
> Max
>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
>
>
>
>
>
>
>
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

Re: [Trinidad] JSF2: Facelet tag metadata

Posted by Matthias Wessendorf <ma...@apache.org>.
Well,

there is only one version of the plugin.
Trunk covers JSF 1.1 and 1.2

The goal is to continue that as well. The branch was just created to
have the (experimental) JSF2 development
not mixed with those changes on trunk.

Do you really feel a need to introduce again a 2-way plugin ?
a) 1.2 and 1.1
b) 2.0

For some of the XSL I already added a check for JSF2

-Matthias

On Thu, Feb 4, 2010 at 9:22 PM, Max Starets <ma...@oracle.com> wrote:
> Matthias,
>
> What do you mean? The change is going only to the 2.0.x branch.
> It will only be used with JSF 2.0+.
>
> Max
>
> Matthias Wessendorf wrote:
>
> Hello Max,
>
> shouldn't we check for the jsfVersion, for the metadata ?
>
> -Matthias
>
> On Thu, Feb 4, 2010 at 6:08 PM, Matthias Wessendorf <ma...@apache.org>
> wrote:
>
>
> +1 - yeah would be nice as the plugins cover already faces cfg part for
> that.
>
> So, feel free to upload the patch, since the impl is done :-)
>
> -M
>
> On Thu, Feb 4, 2010 at 5:57 PM, Blake Sullivan
> <bl...@oracle.com> wrote:
>
>
> +1
>
> -- Blake Sullivan
>
> Max Starets said the following On 2/4/2010 7:57 AM PT:
>
>
> Hello Everyone,
>
> Does anybody have any objections to enhancing Trinidad maven plugins to
> write out Facelet tag metadata
> in taglib xml (see https://issues.apache.org/jira/browse/TRINIDAD-1707)?
>
> I have the implementation ready.
>
> Thanks,
> Max
>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>
>
>
>
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

Re: [Trinidad] JSF2: Facelet tag metadata

Posted by Matthias Wessendorf <ma...@apache.org>.
Hello Max,

shouldn't we check for the jsfVersion, for the metadata ?

-Matthias

On Thu, Feb 4, 2010 at 6:08 PM, Matthias Wessendorf <ma...@apache.org> wrote:
> +1 - yeah would be nice as the plugins cover already faces cfg part for that.
>
> So, feel free to upload the patch, since the impl is done :-)
>
> -M
>
> On Thu, Feb 4, 2010 at 5:57 PM, Blake Sullivan
> <bl...@oracle.com> wrote:
>> +1
>>
>> -- Blake Sullivan
>>
>> Max Starets said the following On 2/4/2010 7:57 AM PT:
>>>
>>> Hello Everyone,
>>>
>>> Does anybody have any objections to enhancing Trinidad maven plugins to
>>> write out Facelet tag metadata
>>> in taglib xml (see https://issues.apache.org/jira/browse/TRINIDAD-1707)?
>>>
>>> I have the implementation ready.
>>>
>>> Thanks,
>>> Max
>>
>>
>
>
>
> --
> Matthias Wessendorf
>
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> twitter: http://twitter.com/mwessendorf
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

Re: [Trinidad] JSF2: Facelet tag metadata

Posted by Matthias Wessendorf <ma...@apache.org>.
+1 - yeah would be nice as the plugins cover already faces cfg part for that.

So, feel free to upload the patch, since the impl is done :-)

-M

On Thu, Feb 4, 2010 at 5:57 PM, Blake Sullivan
<bl...@oracle.com> wrote:
> +1
>
> -- Blake Sullivan
>
> Max Starets said the following On 2/4/2010 7:57 AM PT:
>>
>> Hello Everyone,
>>
>> Does anybody have any objections to enhancing Trinidad maven plugins to
>> write out Facelet tag metadata
>> in taglib xml (see https://issues.apache.org/jira/browse/TRINIDAD-1707)?
>>
>> I have the implementation ready.
>>
>> Thanks,
>> Max
>
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

Re: [Trinidad] JSF2: Facelet tag metadata

Posted by Blake Sullivan <bl...@oracle.com>.
+1

-- Blake Sullivan

Max Starets said the following On 2/4/2010 7:57 AM PT:
> Hello Everyone,
>
> Does anybody have any objections to enhancing Trinidad maven plugins 
> to write out Facelet tag metadata
> in taglib xml (see https://issues.apache.org/jira/browse/TRINIDAD-1707)?
>
> I have the implementation ready.
>
> Thanks,
> Max