You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "niyamsw (via GitHub)" <gi...@apache.org> on 2024/12/04 14:07:16 UTC
[PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
niyamsw opened a new pull request, #10038:
URL: https://github.com/apache/cloudstack/pull/10038
### Description
This PR introduces support for cloudstack-agent on KVM on the s390x and cloudstack-management-server on s390x architecture.
KVM is supported on s390x (IBM Z and LinuxONE) architecture, [Linux KVM Processor Support Page](https://www.linux-kvm.org/page/Processor_support#IBM_z).
I have built a new s390x version of the System VM template: [ [Refer: s390x Build instructions and System VM Template guide.](https://github.com/linux-on-ibm-z/docs/wiki/Building-CloudStack)]
I have tested the deployment of VMs and confirmed that the Virtual Router (VR), SSVM, Console Proxy functionalities worked as expected.
Testing was performed with Debian 11 templates that are compatible with s390x in CloudStack.
I have tested with agent and management server on the following distributions:
- RHEL
- Ubuntu
- SLES
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):


### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2538720705
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2538719182
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2517710566
great to see this integration effort @niyamsw , welcome to the crowd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2527141730
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2622140863
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#discussion_r1869688692
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2754,7 +2762,9 @@ protected FeaturesDef createFeaturesDef(Map<String, String> customParams, boolea
FeaturesDef features = new FeaturesDef();
features.addFeatures(PAE);
features.addFeatures(APIC);
- features.addFeatures(ACPI);
+ if (!"s390x".equals(System.getProperty("os.arch"))) {
Review Comment:
may be better to create a method like
```
private boolean isHostS390x() {
return S390X.equals(System.getProperty("os.arch");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2527138157
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2527253916
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2517896196
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10038?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `32.00000%` with `17 lines` in your changes missing coverage. Please review.
> Project coverage is 16.90%. Comparing base [(`4ac4d9c`)](https://app.codecov.io/gh/apache/cloudstack/commit/4ac4d9cf29abd83526093d162424da0419496297?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`0aa422f`)](https://app.codecov.io/gh/apache/cloudstack/commit/0aa422f3709baf3bbe78fe6024f1f461ad79bf85?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 13 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/cloudstack/pull/10038?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&filepath=plugins%2Fhypervisors%2Fkvm%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhypervisor%2Fkvm%2Fresource%2FLibvirtComputingResource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | 41.17% | [3 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&filepath=plugins%2Fhypervisors%2Fkvm%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhypervisor%2Fkvm%2Fresource%2FLibvirtVMDef.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | 25.00% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/cloudstack/utils/linux/KVMHostInfo.java](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&filepath=plugins%2Fhypervisors%2Fkvm%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fcloudstack%2Futils%2Flinux%2FKVMHostInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svdXRpbHMvbGludXgvS1ZNSG9zdEluZm8uamF2YQ==) | 0.00% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/com/cloud/hypervisor/HypervisorGuruBase.java](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fhypervisor%2FHypervisorGuruBase.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2h5cGVydmlzb3IvSHlwZXJ2aXNvckd1cnVCYXNlLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/cloudstack/pull/10038?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #10038 +/- ##
============================================
+ Coverage 16.06% 16.90% +0.84%
- Complexity 12860 12865 +5
============================================
Files 5640 5247 -393
Lines 493753 461444 -32309
Branches 59854 54154 -5700
============================================
- Hits 79323 78030 -1293
+ Misses 405649 374773 -30876
+ Partials 8781 8641 -140
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10038/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10038/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10038/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.90% <32.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10038?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2519960567
@niyamsw
`"s390x".equals(System.getProperty("os.arch")` is used in several lines, we can replace them.
it checks if the host is s390x, is it same as `isGuestS390x` ?
in another word, should the host arch and guest arch be s390x ? for example, can x86_64 vms be deployed on a s390x host ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "niyamsw (via GitHub)" <gi...@apache.org>.
niyamsw commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2622059982
Just following up on this PR. Any feedback or next steps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2517514037
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:
- In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
- Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
- Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
- Please follow [ASF Code of Conduct](https://github.com/apache/.github/blob/main/.github/CODE_OF_CONDUCT.md) for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
- Be sure to read the [CloudStack Coding Conventions](https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventions).
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#discussion_r1871154421
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -247,8 +247,8 @@ public class LibvirtComputingResource extends ServerResourceBase implements Serv
/**
* Machine type.
*/
- private static final String PC = "pc";
- private static final String VIRT = "virt";
+ private static final String PC = ("s390x".equals(System.getProperty("os.arch"))) ? "s390-ccw-virtio" : "pc";
Review Comment:
can define a constant for `s390-ccw-virtio`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "niyam-choudhari (via GitHub)" <gi...@apache.org>.
niyam-choudhari commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2528235326
> @niyamsw `"s390x".equals(System.getProperty("os.arch")` is used in several lines, we can replace them.
>
> it checks if the host is s390x, is it same as `isGuestS390x` ? in another word, should the host arch and guest arch be s390x ? for example, can x86_64 vms be deployed on a s390x host ?
This PR is only for introducing support for KVM on s390x host and s390x guests.
I have refactored the code as suggested and added isHostS390x() function to make the code more streamlined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "niyamsw (via GitHub)" <gi...@apache.org>.
niyamsw commented on code in PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#discussion_r1870693705
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2754,7 +2762,9 @@ protected FeaturesDef createFeaturesDef(Map<String, String> customParams, boolea
FeaturesDef features = new FeaturesDef();
features.addFeatures(PAE);
features.addFeatures(APIC);
- features.addFeatures(ACPI);
+ if (!"s390x".equals(System.getProperty("os.arch"))) {
Review Comment:
reused existing isGuestS390x() method for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KVM/s390x Support: Add support for KVM on s390x architecture [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10038:
URL: https://github.com/apache/cloudstack/pull/10038#issuecomment-2540451835
<b>[SF] Trillian test result (tid-11892)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10038-t11892-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_secure_vm_migration | `Error` | 405.43 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org