You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/11/15 08:42:00 UTC
Review Request 63828: Added authorization tests for standalone
container APIs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63828/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu.
Repository: mesos
Description
-------
The usage of the standalone container APIs is rather coarse-grained.
A principal can either use the APIs, or it cannot. This is the case
for all four actions: Launch, Wait, Kill, and Remove.
Diffs
-----
src/tests/authorization_tests.cpp f2e86e22f789a4d65105f737e6546bc050872bb2
Diff: https://reviews.apache.org/r/63828/diff/1/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 63828: Added authorization tests for standalone
container APIs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63828/#review191053
-----------------------------------------------------------
PASS: Mesos patch 63828 was successfully built and tested.
Reviews applied: `['63828']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63828
- Mesos Reviewbot Windows
On Nov. 15, 2017, 8:42 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63828/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2017, 8:42 a.m.)
>
>
> Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The usage of the standalone container APIs is rather coarse-grained.
> A principal can either use the APIs, or it cannot. This is the case
> for all four actions: Launch, Wait, Kill, and Remove.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp f2e86e22f789a4d65105f737e6546bc050872bb2
>
>
> Diff: https://reviews.apache.org/r/63828/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 63828: Added authorization tests for standalone
container APIs.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63828/#review195645
-----------------------------------------------------------
PASS: Mesos patch 63828 was successfully built and tested.
Reviews applied: `['63828']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63828
- Mesos Reviewbot Windows
On Jan. 17, 2018, 7:21 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63828/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2018, 7:21 p.m.)
>
>
> Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The usage of the standalone container APIs is rather coarse-grained.
> A principal can either use the APIs, or it cannot. This is the case
> for all four actions: Launch, Wait, Kill, and Remove.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c
>
>
> Diff: https://reviews.apache.org/r/63828/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 63828: Added authorization tests for standalone
container APIs.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63828/
-----------------------------------------------------------
(Updated Jan. 17, 2018, 11:21 a.m.)
Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu.
Changes
-------
Rebased and updated symbols to include the plural-ized protobuf fields.
Repository: mesos
Description
-------
The usage of the standalone container APIs is rather coarse-grained.
A principal can either use the APIs, or it cannot. This is the case
for all four actions: Launch, Wait, Kill, and Remove.
Diffs (updated)
-----
src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c
Diff: https://reviews.apache.org/r/63828/diff/2/
Changes: https://reviews.apache.org/r/63828/diff/1-2/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 63828: Added authorization tests for standalone
container APIs.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63828/#review191043
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Nov. 15, 2017, 9:42 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63828/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2017, 9:42 a.m.)
>
>
> Review request for mesos, Alexander Rojas, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The usage of the standalone container APIs is rather coarse-grained.
> A principal can either use the APIs, or it cannot. This is the case
> for all four actions: Launch, Wait, Kill, and Remove.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp f2e86e22f789a4d65105f737e6546bc050872bb2
>
>
> Diff: https://reviews.apache.org/r/63828/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>