Re: [PR] KAFKA-18209 Cleanup `__transaction_state` config logic [kafka]

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #18201:
URL: https://github.com/apache/kafka/pull/18201#discussion_r1939703891


##########
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##########
@@ -45,6 +46,15 @@ import org.apache.kafka.storage.internals.log.AppendOrigin
 import scala.jdk.CollectionConverters._
 import scala.collection.mutable
 
+object TransactionStateManager {
+  // enforce always using
+  //  1. cleanup policy = compact
+  //  2. compression = none
+  //  3. unclean leader election = disabled
+  //  4. required acks = -1 when writing
+  val EnforcedCompression: Compression = Compression.NONE

Review Comment:
   We also want to use these fields in `transactionTopicConfigs()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org