You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ol...@apache.org on 2016/12/18 10:15:02 UTC

svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Author: olli
Date: Sun Dec 18 10:15:02 2016
New Revision: 1774871

URL: http://svn.apache.org/viewvc?rev=1774871&view=rev
Log:
SLING-6411 Upgrade Karaf to 4.1

disable Jenkins build jobs due to use of external snapshots

Modified:
    sling/trunk/tooling/jenkins/create_jobs.groovy

Modified: sling/trunk/tooling/jenkins/create_jobs.groovy
URL: http://svn.apache.org/viewvc/sling/trunk/tooling/jenkins/create_jobs.groovy?rev=1774871&r1=1774870&r2=1774871&view=diff
==============================================================================
--- sling/trunk/tooling/jenkins/create_jobs.groovy (original)
+++ sling/trunk/tooling/jenkins/create_jobs.groovy Sun Dec 18 10:15:02 2016
@@ -32,7 +32,7 @@ def modules = [
     ],
     [
         location: 'bundles/commons/log-webconsole'
-    ],    
+    ],
     [
         location: 'bundles/commons/logservice'
     ],
@@ -593,24 +593,24 @@ def modules = [
     [
         location: "installer/providers/file"
     ],
-    [
-        location: 'karaf/org.apache.sling.karaf-distribution'
-    ],
-    [
-        location: 'karaf/org.apache.sling.karaf-features'
-    ],
-    [
-        location: 'karaf/org.apache.sling.karaf-integration-tests'
-    ],
-    [
-        location: 'karaf/org.apache.sling.karaf-launchpad-oak-tar-integration-tests'
-    ],
-    [
-        location: 'karaf/org.apache.sling.karaf-repoinit'
-    ],
-    [
-        location: 'karaf/org.apache.sling.karaf-configs'
-    ],
+//    [
+//        location: 'karaf/org.apache.sling.karaf-distribution'
+//    ],
+//    [
+//        location: 'karaf/org.apache.sling.karaf-features'
+//    ],
+//    [
+//        location: 'karaf/org.apache.sling.karaf-integration-tests'
+//    ],
+//    [
+//        location: 'karaf/org.apache.sling.karaf-launchpad-oak-tar-integration-tests'
+//    ],
+//    [
+//        location: 'karaf/org.apache.sling.karaf-repoinit'
+//    ],
+//    [
+//        location: 'karaf/org.apache.sling.karaf-configs'
+//    ],
     [
         location: 'launchpad/api',
         jdks: ["1.8"]
@@ -915,7 +915,7 @@ for more details</p>''')
             // job is triggered first and we may end up with a
             // mix of Java 7 and Java 8 artifacts for projects which
             // use these 2 versions
-            def extraGoalsParams = module.extraGoalsParams ?: "" 
+            def extraGoalsParams = module.extraGoalsParams ?: ""
             goals( (deploy ? "-U clean deploy" : "-U clean verify") + " " + extraGoalsParams)
 
             publishers {



Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Robert Munteanu <ro...@apache.org>.
Ping :-)


On Mon, 2016-12-19 at 11:33 +0200, Robert Munteanu wrote:
> Hi Olli,
> 
> I guess you just discovered why we don't allow SNAPSHOT dependencies
> to
> external projects in trunk :-)
> 
> Rather than remove the jobs, please work on a branch if you have work
> that requires SNAPSHOT dependencies. That's what we did for the IDE
> tooling until FileVault was released, for instance.
> 
> This way both the Jenkins jobs and other contributors/committers
> besides yourself can build the Karaf integration.
> 
> Thanks,
> 
> Robert
> 
> On Sun, 2016-12-18 at 10:15 +0000, olli@apache.org wrote:
> > Author: olli
> > Date: Sun Dec 18 10:15:02 2016
> > New Revision: 1774871
> > 
> > URL: http://svn.apache.org/viewvc?rev=1774871&view=rev
> > Log:
> > SLING-6411 Upgrade Karaf to 4.1
> > 
> > disable Jenkins build jobs due to use of external snapshots
> > 
> > Modified:
> > ����sling/trunk/tooling/jenkins/create_jobs.groovy
> > 
> > Modified: sling/trunk/tooling/jenkins/create_jobs.groovy
> > URL: http://svn.apache.org/viewvc/sling/trunk/tooling/jenkins/creat
> > e_
> > jobs.groovy?rev=1774871&r1=1774870&r2=1774871&view=diff
> > ===================================================================
> > ==
> > =========
> > --- sling/trunk/tooling/jenkins/create_jobs.groovy (original)
> > +++ sling/trunk/tooling/jenkins/create_jobs.groovy Sun Dec 18
> > 10:15:02 2016
> > @@ -32,7 +32,7 @@ def modules = [
> > �����],
> > �����[
> > ���������location: 'bundles/commons/log-webconsole'
> > -����],����
> > +����],
> > �����[
> > ���������location: 'bundles/commons/logservice'
> > �����],
> > @@ -593,24 +593,24 @@ def modules = [
> > �����[
> > ���������location: "installer/providers/file"
> > �����],
> > -����[
> > -��������location: 'karaf/org.apache.sling.karaf-distribution'
> > -����],
> > -����[
> > -��������location: 'karaf/org.apache.sling.karaf-features'
> > -����],
> > -����[
> > -��������location: 'karaf/org.apache.sling.karaf-integration-tests'
> > -����],
> > -����[
> > -��������location: 'karaf/org.apache.sling.karaf-launchpad-oak-tar-
> > integration-tests'
> > -����],
> > -����[
> > -��������location: 'karaf/org.apache.sling.karaf-repoinit'
> > -����],
> > -����[
> > -��������location: 'karaf/org.apache.sling.karaf-configs'
> > -����],
> > +//����[
> > +//��������location: 'karaf/org.apache.sling.karaf-distribution'
> > +//����],
> > +//����[
> > +//��������location: 'karaf/org.apache.sling.karaf-features'
> > +//����],
> > +//����[
> > +//��������location: 'karaf/org.apache.sling.karaf-integration-
> > tests'
> > +//����],
> > +//����[
> > +//��������location: 'karaf/org.apache.sling.karaf-launchpad-oak-
> > tar-
> > integration-tests'
> > +//����],
> > +//����[
> > +//��������location: 'karaf/org.apache.sling.karaf-repoinit'
> > +//����],
> > +//����[
> > +//��������location: 'karaf/org.apache.sling.karaf-configs'
> > +//����],
> > �����[
> > ���������location: 'launchpad/api',
> > ���������jdks: ["1.8"]
> > @@ -915,7 +915,7 @@ for more details</p>''')
> > �������������// job is triggered first and we may end up with a
> > �������������// mix of Java 7 and Java 8 artifacts for projects
> > which
> > �������������// use these 2 versions
> > -������������def extraGoalsParams = module.extraGoalsParams ?: ""�
> > +������������def extraGoalsParams = module.extraGoalsParams ?: ""
> > �������������goals( (deploy ? "-U clean deploy" : "-U clean
> > verify")
> > + " " + extraGoalsParams)
> > �
> > �������������publishers {
> > 
> > 
> 
> 


Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 21 December 2016 18:48:59 Robert Munteanu wrote:
> On Wed, 2016-12-21 at 16:46 +0100, Oliver Lietz wrote:
> > Well, the extra work of branching and merging in SVN. It's my spare
> > time I 
> > spend on Sling.
> > 
> > The Sling/Karaf build is frequently broken by other developers who do
> > not care 
> > about those modules. Especially the org.apache.sling.karaf-launchpad-
> > oak-tar-
> > integration-tests module where I have to use snapshots of test
> > bundles.
> 
> How can we find out if we broke something in the Karaf integration?

Failing integration tests... ;)

We have a bootstrap test for every feature (and some additional tests) in 
karaf-integration-tests and running Launchpad's ITs in karaf-launchpad-oak-
tar-integration-tests against Sling/Karaf (with Oak Tar). That is a fairly 
good coverage.

Happy New Year, all!

O. 

> > I'm not happy with the current situation either but trying to get it
> > fixed 
> > (see related issues in upstream projects also: Karaf, Pax Web, Pax
> > Exam).
> 
> And that is very much appreciated.
> 
> Robert
> 
> > The same time I switched to Karaf snapshots the README was updated
> > and every 
> > move is documented in JIRA. So it should be very clear that it is
> > work in 
> > progress.
> > 
> > Regards,
> > O.



Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2016-12-21 at 16:46 +0100, Oliver Lietz wrote:
> Well, the extra work of branching and merging in SVN. It's my spare
> time I�
> spend on Sling.
> 
> The Sling/Karaf build is frequently broken by other developers who do
> not care�
> about those modules. Especially the org.apache.sling.karaf-launchpad-
> oak-tar-
> integration-tests module where I have to use snapshots of test
> bundles.

How can we find out if we broke something in the Karaf integration?

> 
> I'm not happy with the current situation either but trying to get it
> fixed�
> (see related issues in upstream projects also: Karaf, Pax Web, Pax
> Exam).

And that is very much appreciated.

Robert

> 
> The same time I switched to Karaf snapshots the README was updated
> and every�
> move is documented in JIRA. So it should be very clear that it is
> work in�
> progress.
> 
> Regards,
> O.


Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 21 December 2016 17:02:49 Robert Munteanu wrote:
> On Wed, 2016-12-21 at 15:46 +0100, Oliver Lietz wrote:
> > On Monday 19 December 2016 11:33:54 Robert Munteanu wrote:
> > > Hi Olli,
> > 
> > Hi Robert,
> > 
> > > I guess you just discovered why we don't allow SNAPSHOT
> > > dependencies to
> > > external projects in trunk :-)
> > 
> > no, I'm aware that external SNAPSHOTs are not accessible in our
> > default build 
> > setup and disabled all Karaf build jobs _before_ using them.
> 
> Right, that does indeed save us the trouble of being flooded by
> notifications, which is appreciated.
> 
> > > Rather than remove the jobs, please work on a branch if you have
> > > work
> > > that requires SNAPSHOT dependencies. That's what we did for the IDE
> > > tooling until FileVault was released, for instance.
> > > 
> > > This way both the Jenkins jobs and other contributors/committers
> > > besides yourself can build the Karaf integration.
> > 
> > Further development is blocked as Sling requires R6 Http features
> > which are 
> > not available with Karaf 4.0. I have to use Karaf 4.1-SNAPSHOT and
> > Pax Web 
> > 6.0-SNAPSHOT, please see SLING-6411.
> 
> Ack
> 
> > We hadn't a release yet and there are no other Sling developers
> > moving 
> > Sling/Karaf forward – so I don't see a problem in disabling the build
> > jobs.
> 
> Ack. My point was not about the build jobs, it's about keeping trunk in
> a buildable state at all times.
> 
> I understand your argument about no release and no other contributors.
> However, we don't know who is trying to build the SVN repository and
> who is interested in the Karaf integration. They might try building it
> only to have it fail due to missing dependencies.
> 
> I like simple rules :-) one of those is having trunk always build.
> 
> What would be the disadvantage of working with SNAPSHOTs in branches
> and merging back to trunk once we have releases of the respective
> projects?

Well, the extra work of branching and merging in SVN. It's my spare time I 
spend on Sling.

The Sling/Karaf build is frequently broken by other developers who do not care 
about those modules. Especially the org.apache.sling.karaf-launchpad-oak-tar-
integration-tests module where I have to use snapshots of test bundles.

I'm not happy with the current situation either but trying to get it fixed 
(see related issues in upstream projects also: Karaf, Pax Web, Pax Exam).

The same time I switched to Karaf snapshots the README was updated and every 
move is documented in JIRA. So it should be very clear that it is work in 
progress.

Regards,
O.

> Thanks,
> 
> Robert
> 
> > Thanks,
> > O.
> > 
> > > Thanks,
> > > 
> > > Robert
> > > 
> > > On Sun, 2016-12-18 at 10:15 +0000, olli@apache.org wrote:
> > > > Author: olli
> > > > Date: Sun Dec 18 10:15:02 2016
> > > > New Revision: 1774871
> > > > 
> > > > URL: http://svn.apache.org/viewvc?rev=1774871&view=rev
> > > > Log:
> > > > SLING-6411 Upgrade Karaf to 4.1
> > > > 
> > > > disable Jenkins build jobs due to use of external snapshots
> > > > 
> > > > Modified:
> > > >     sling/trunk/tooling/jenkins/create_jobs.groovy
> > > > 
> > > > Modified: sling/trunk/tooling/jenkins/create_jobs.groovy
> > > > URL: http://svn.apache.org/viewvc/sling/trunk/tooling/jenkins/cre
> > > > ate_
> > > > jobs.groovy?rev=1774871&r1=1774870&r2=1774871&view=diff
> > > > =================================================================
> > > > ====
> > > > =========
> > > > --- sling/trunk/tooling/jenkins/create_jobs.groovy (original)
> > > > +++ sling/trunk/tooling/jenkins/create_jobs.groovy Sun Dec 18
> > > > 10:15:02 2016
> > > > @@ -32,7 +32,7 @@ def modules = [
> > > >      ],
> > > >      [
> > > >          location: 'bundles/commons/log-webconsole'
> > > > -    ],    
> > > > +    ],
> > > >      [
> > > >          location: 'bundles/commons/logservice'
> > > >      ],
> > > > @@ -593,24 +593,24 @@ def modules = [
> > > >      [
> > > >          location: "installer/providers/file"
> > > >      ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-distribution'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-features'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-integration-
> > > > tests'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-launchpad-oak-
> > > > tar-
> > > > integration-tests'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-repoinit'
> > > > -    ],
> > > > -    [
> > > > -        location: 'karaf/org.apache.sling.karaf-configs'
> > > > -    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-distribution'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-features'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-integration-
> > > > tests'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-launchpad-oak-
> > > > tar-
> > > > integration-tests'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-repoinit'
> > > > +//    ],
> > > > +//    [
> > > > +//        location: 'karaf/org.apache.sling.karaf-configs'
> > > > +//    ],
> > > >      [
> > > >          location: 'launchpad/api',
> > > >          jdks: ["1.8"]
> > > > @@ -915,7 +915,7 @@ for more details</p>''')
> > > >              // job is triggered first and we may end up with a
> > > >              // mix of Java 7 and Java 8 artifacts for projects
> > > > which
> > > >              // use these 2 versions
> > > > -            def extraGoalsParams = module.extraGoalsParams ?:
> > > > "" 
> > > > +            def extraGoalsParams = module.extraGoalsParams ?: ""
> > > >              goals( (deploy ? "-U clean deploy" : "-U clean
> > > > verify")
> > > > + " " + extraGoalsParams)
> > > >  
> > > >              publishers {



Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 21 December 2016 18:49:53 Robert Munteanu wrote:
> On Wed, 2016-12-21 at 17:07 +0100, Oliver Lietz wrote:
> > On Wednesday 21 December 2016 16:16:36 Bertrand Delacretaz wrote:
> > > On Wed, Dec 21, 2016 at 4:02 PM, Robert Munteanu <rombert@apache.or
> > > 
> > > g> wrote:
> > > > ...What would be the disadvantage of working with SNAPSHOTs in
> > > > branches
> > > > and merging back to trunk once we have releases of the respective
> > > > projects?...
> > > 
> > > IMO the problem is that this makes that work essentially
> > > "invisible"
> > > to others as we do not usually work with svn branches.
> > 
> > Good point.
> > 
> > > We could use instead a Maven profile in the main pom for such
> > > modules
> > > that require external snapshots. Disabled by default, so the trunk
> > > builds and one can easily re-enable those modules as needed.
> > 
> > That does not work unfortunately. The Sling Karaf modules will fail
> > with 
> > latest Sling releases because of missing R6 Http support.
> > I stopped updating some dependencies (using the Http Whiteboard, e.g.
> > Engine, 
> > Rewriter, i18n) but the gap is getting bigger and bigger every day
> > and hard to 
> > catch up. Other parts of Sling are also moving fast and need special
> > attention 
> > (e.g. Login Admin Whitelist and system users).
> > 
> > I'm close again (test with Oak Mongo is broken and
> > org.apache.sling.karaf-
> > launchpad-oak-tar-integration-tests has issues) at the cost of not
> > having a 
> > Jenkins build until all required upstream projects are released.
> 
> I double-checked, and the Karaf modules are not part of the main
> reactor anyway.
> 
> How far away are we from upstream releases of Karaf and Pax-Exam?

Karaf 4.1 is scheduled for (December 2016) January 2017. If I will find some 
time this week for Pax Exam I do the release of 4.10.

O.

> Robert


Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2016-12-21 at 17:07 +0100, Oliver Lietz wrote:
> On Wednesday 21 December 2016 16:16:36 Bertrand Delacretaz wrote:
> > On Wed, Dec 21, 2016 at 4:02 PM, Robert Munteanu <rombert@apache.or
> > g> wrote:
> > > ...What would be the disadvantage of working with SNAPSHOTs in
> > > branches
> > > and merging back to trunk once we have releases of the respective
> > > projects?...
> > 
> > IMO the problem is that this makes that work essentially
> > "invisible"
> > to others as we do not usually work with svn branches.
> 
> Good point.
> 
> > We could use instead a Maven profile in the main pom for such
> > modules
> > that require external snapshots. Disabled by default, so the trunk
> > builds and one can easily re-enable those modules as needed.
> 
> That does not work unfortunately. The Sling Karaf modules will fail
> with�
> latest Sling releases because of missing R6 Http support.
> I stopped updating some dependencies (using the Http Whiteboard, e.g.
> Engine,�
> Rewriter, i18n) but the gap is getting bigger and bigger every day
> and hard to�
> catch up. Other parts of Sling are also moving fast and need special
> attention�
> (e.g. Login Admin Whitelist and system users).
> 
> I'm close again (test with Oak Mongo is broken and
> org.apache.sling.karaf-
> launchpad-oak-tar-integration-tests has issues) at the cost of not
> having a�
> Jenkins build until all required upstream projects are released.

I double-checked, and the Karaf modules are not part of the main
reactor anyway.

How far away are we from upstream releases of Karaf and Pax-Exam?

Robert

Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 21 December 2016 16:16:36 Bertrand Delacretaz wrote:
> On Wed, Dec 21, 2016 at 4:02 PM, Robert Munteanu <ro...@apache.org> wrote:
> > ...What would be the disadvantage of working with SNAPSHOTs in branches
> > and merging back to trunk once we have releases of the respective
> > projects?...
> 
> IMO the problem is that this makes that work essentially "invisible"
> to others as we do not usually work with svn branches.

Good point.

> We could use instead a Maven profile in the main pom for such modules
> that require external snapshots. Disabled by default, so the trunk
> builds and one can easily re-enable those modules as needed.

That does not work unfortunately. The Sling Karaf modules will fail with 
latest Sling releases because of missing R6 Http support.
I stopped updating some dependencies (using the Http Whiteboard, e.g. Engine, 
Rewriter, i18n) but the gap is getting bigger and bigger every day and hard to 
catch up. Other parts of Sling are also moving fast and need special attention 
(e.g. Login Admin Whitelist and system users).

I'm close again (test with Oak Mongo is broken and org.apache.sling.karaf-
launchpad-oak-tar-integration-tests has issues) at the cost of not having a 
Jenkins build until all required upstream projects are released.

O.

> -Bertrand


Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Bertrand Delacretaz <bd...@apache.org>.
On Wed, Dec 21, 2016 at 4:02 PM, Robert Munteanu <ro...@apache.org> wrote:
> ...What would be the disadvantage of working with SNAPSHOTs in branches
> and merging back to trunk once we have releases of the respective
> projects?...

IMO the problem is that this makes that work essentially "invisible"
to others as we do not usually work with svn branches.

We could use instead a Maven profile in the main pom for such modules
that require external snapshots. Disabled by default, so the trunk
builds and one can easily re-enable those modules as needed.

-Bertrand

Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2016-12-21 at 15:46 +0100, Oliver Lietz wrote:
> On Monday 19 December 2016 11:33:54 Robert Munteanu wrote:
> > Hi Olli,
> 
> Hi Robert,
> 
> > I guess you just discovered why we don't allow SNAPSHOT
> > dependencies to
> > external projects in trunk :-)
> 
> no, I'm aware that external SNAPSHOTs are not accessible in our
> default build�
> setup and disabled all Karaf build jobs _before_ using them.

Right, that does indeed save us the trouble of being flooded by
notifications, which is appreciated.

> 
> > Rather than remove the jobs, please work on a branch if you have
> > work
> > that requires SNAPSHOT dependencies. That's what we did for the IDE
> > tooling until FileVault was released, for instance.
> > 
> > This way both the Jenkins jobs and other contributors/committers
> > besides yourself can build the Karaf integration.
> 
> Further development is blocked as Sling requires R6 Http features
> which are�
> not available with Karaf 4.0. I have to use Karaf 4.1-SNAPSHOT and
> Pax Web�
> 6.0-SNAPSHOT, please see SLING-6411.

Ack

> 
> We hadn't a release yet and there are no other Sling developers
> moving�
> Sling/Karaf forward \u2013 so I don't see a problem in disabling the build
> jobs.

Ack. My point was not about the build jobs, it's about keeping trunk in
a buildable state at all times.

I understand your argument about no release and no other contributors.
However, we don't know who is trying to build the SVN repository and
who is interested in the Karaf integration. They might try building it
only to have it fail due to missing dependencies.

I like simple rules :-) one of those is having trunk always build.

What would be the disadvantage of working with SNAPSHOTs in branches
and merging back to trunk once we have releases of the respective
projects?

Thanks,

Robert

> 
> Thanks,
> O.
> 
> > Thanks,
> > 
> > Robert
> > 
> > On Sun, 2016-12-18 at 10:15 +0000, olli@apache.org wrote:
> > > Author: olli
> > > Date: Sun Dec 18 10:15:02 2016
> > > New Revision: 1774871
> > > 
> > > URL: http://svn.apache.org/viewvc?rev=1774871&view=rev
> > > Log:
> > > SLING-6411 Upgrade Karaf to 4.1
> > > 
> > > disable Jenkins build jobs due to use of external snapshots
> > > 
> > > Modified:
> > > ����sling/trunk/tooling/jenkins/create_jobs.groovy
> > > 
> > > Modified: sling/trunk/tooling/jenkins/create_jobs.groovy
> > > URL: http://svn.apache.org/viewvc/sling/trunk/tooling/jenkins/cre
> > > ate_
> > > jobs.groovy?rev=1774871&r1=1774870&r2=1774871&view=diff
> > > =================================================================
> > > ====
> > > =========
> > > --- sling/trunk/tooling/jenkins/create_jobs.groovy (original)
> > > +++ sling/trunk/tooling/jenkins/create_jobs.groovy Sun Dec 18
> > > 10:15:02 2016
> > > @@ -32,7 +32,7 @@ def modules = [
> > > �����],
> > > �����[
> > > ���������location: 'bundles/commons/log-webconsole'
> > > -����],����
> > > +����],
> > > �����[
> > > ���������location: 'bundles/commons/logservice'
> > > �����],
> > > @@ -593,24 +593,24 @@ def modules = [
> > > �����[
> > > ���������location: "installer/providers/file"
> > > �����],
> > > -����[
> > > -��������location: 'karaf/org.apache.sling.karaf-distribution'
> > > -����],
> > > -����[
> > > -��������location: 'karaf/org.apache.sling.karaf-features'
> > > -����],
> > > -����[
> > > -��������location: 'karaf/org.apache.sling.karaf-integration-
> > > tests'
> > > -����],
> > > -����[
> > > -��������location: 'karaf/org.apache.sling.karaf-launchpad-oak-
> > > tar-
> > > integration-tests'
> > > -����],
> > > -����[
> > > -��������location: 'karaf/org.apache.sling.karaf-repoinit'
> > > -����],
> > > -����[
> > > -��������location: 'karaf/org.apache.sling.karaf-configs'
> > > -����],
> > > +//����[
> > > +//��������location: 'karaf/org.apache.sling.karaf-distribution'
> > > +//����],
> > > +//����[
> > > +//��������location: 'karaf/org.apache.sling.karaf-features'
> > > +//����],
> > > +//����[
> > > +//��������location: 'karaf/org.apache.sling.karaf-integration-
> > > tests'
> > > +//����],
> > > +//����[
> > > +//��������location: 'karaf/org.apache.sling.karaf-launchpad-oak-
> > > tar-
> > > integration-tests'
> > > +//����],
> > > +//����[
> > > +//��������location: 'karaf/org.apache.sling.karaf-repoinit'
> > > +//����],
> > > +//����[
> > > +//��������location: 'karaf/org.apache.sling.karaf-configs'
> > > +//����],
> > > �����[
> > > ���������location: 'launchpad/api',
> > > ���������jdks: ["1.8"]
> > > @@ -915,7 +915,7 @@ for more details</p>''')
> > > �������������// job is triggered first and we may end up with a
> > > �������������// mix of Java 7 and Java 8 artifacts for projects
> > > which
> > > �������������// use these 2 versions
> > > -������������def extraGoalsParams = module.extraGoalsParams ?:
> > > ""�
> > > +������������def extraGoalsParams = module.extraGoalsParams ?: ""
> > > �������������goals( (deploy ? "-U clean deploy" : "-U clean
> > > verify")
> > > + " " + extraGoalsParams)
> > > �
> > > �������������publishers {
> 
> 


Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Monday 19 December 2016 11:33:54 Robert Munteanu wrote:
> Hi Olli,

Hi Robert,

> I guess you just discovered why we don't allow SNAPSHOT dependencies to
> external projects in trunk :-)

no, I'm aware that external SNAPSHOTs are not accessible in our default build 
setup and disabled all Karaf build jobs _before_ using them.

> Rather than remove the jobs, please work on a branch if you have work
> that requires SNAPSHOT dependencies. That's what we did for the IDE
> tooling until FileVault was released, for instance.
> 
> This way both the Jenkins jobs and other contributors/committers
> besides yourself can build the Karaf integration.

Further development is blocked as Sling requires R6 Http features which are 
not available with Karaf 4.0. I have to use Karaf 4.1-SNAPSHOT and Pax Web 
6.0-SNAPSHOT, please see SLING-6411.

We hadn't a release yet and there are no other Sling developers moving 
Sling/Karaf forward – so I don't see a problem in disabling the build jobs.

Thanks,
O.

> Thanks,
> 
> Robert
> 
> On Sun, 2016-12-18 at 10:15 +0000, olli@apache.org wrote:
> > Author: olli
> > Date: Sun Dec 18 10:15:02 2016
> > New Revision: 1774871
> > 
> > URL: http://svn.apache.org/viewvc?rev=1774871&view=rev
> > Log:
> > SLING-6411 Upgrade Karaf to 4.1
> > 
> > disable Jenkins build jobs due to use of external snapshots
> > 
> > Modified:
> >     sling/trunk/tooling/jenkins/create_jobs.groovy
> > 
> > Modified: sling/trunk/tooling/jenkins/create_jobs.groovy
> > URL: http://svn.apache.org/viewvc/sling/trunk/tooling/jenkins/create_
> > jobs.groovy?rev=1774871&r1=1774870&r2=1774871&view=diff
> > =====================================================================
> > =========
> > --- sling/trunk/tooling/jenkins/create_jobs.groovy (original)
> > +++ sling/trunk/tooling/jenkins/create_jobs.groovy Sun Dec 18
> > 10:15:02 2016
> > @@ -32,7 +32,7 @@ def modules = [
> >      ],
> >      [
> >          location: 'bundles/commons/log-webconsole'
> > -    ],    
> > +    ],
> >      [
> >          location: 'bundles/commons/logservice'
> >      ],
> > @@ -593,24 +593,24 @@ def modules = [
> >      [
> >          location: "installer/providers/file"
> >      ],
> > -    [
> > -        location: 'karaf/org.apache.sling.karaf-distribution'
> > -    ],
> > -    [
> > -        location: 'karaf/org.apache.sling.karaf-features'
> > -    ],
> > -    [
> > -        location: 'karaf/org.apache.sling.karaf-integration-tests'
> > -    ],
> > -    [
> > -        location: 'karaf/org.apache.sling.karaf-launchpad-oak-tar-
> > integration-tests'
> > -    ],
> > -    [
> > -        location: 'karaf/org.apache.sling.karaf-repoinit'
> > -    ],
> > -    [
> > -        location: 'karaf/org.apache.sling.karaf-configs'
> > -    ],
> > +//    [
> > +//        location: 'karaf/org.apache.sling.karaf-distribution'
> > +//    ],
> > +//    [
> > +//        location: 'karaf/org.apache.sling.karaf-features'
> > +//    ],
> > +//    [
> > +//        location: 'karaf/org.apache.sling.karaf-integration-tests'
> > +//    ],
> > +//    [
> > +//        location: 'karaf/org.apache.sling.karaf-launchpad-oak-tar-
> > integration-tests'
> > +//    ],
> > +//    [
> > +//        location: 'karaf/org.apache.sling.karaf-repoinit'
> > +//    ],
> > +//    [
> > +//        location: 'karaf/org.apache.sling.karaf-configs'
> > +//    ],
> >      [
> >          location: 'launchpad/api',
> >          jdks: ["1.8"]
> > @@ -915,7 +915,7 @@ for more details</p>''')
> >              // job is triggered first and we may end up with a
> >              // mix of Java 7 and Java 8 artifacts for projects which
> >              // use these 2 versions
> > -            def extraGoalsParams = module.extraGoalsParams ?: "" 
> > +            def extraGoalsParams = module.extraGoalsParams ?: ""
> >              goals( (deploy ? "-U clean deploy" : "-U clean verify")
> > + " " + extraGoalsParams)
> >  
> >              publishers {



Re: svn commit: r1774871 - /sling/trunk/tooling/jenkins/create_jobs.groovy

Posted by Robert Munteanu <ro...@apache.org>.
Hi Olli,

I guess you just discovered why we don't allow SNAPSHOT dependencies to
external projects in trunk :-)

Rather than remove the jobs, please work on a branch if you have work
that requires SNAPSHOT dependencies. That's what we did for the IDE
tooling until FileVault was released, for instance.

This way both the Jenkins jobs and other contributors/committers
besides yourself can build the Karaf integration.

Thanks,

Robert

On Sun, 2016-12-18 at 10:15 +0000, olli@apache.org wrote:
> Author: olli
> Date: Sun Dec 18 10:15:02 2016
> New Revision: 1774871
> 
> URL: http://svn.apache.org/viewvc?rev=1774871&view=rev
> Log:
> SLING-6411 Upgrade Karaf to 4.1
> 
> disable Jenkins build jobs due to use of external snapshots
> 
> Modified:
> ����sling/trunk/tooling/jenkins/create_jobs.groovy
> 
> Modified: sling/trunk/tooling/jenkins/create_jobs.groovy
> URL: http://svn.apache.org/viewvc/sling/trunk/tooling/jenkins/create_
> jobs.groovy?rev=1774871&r1=1774870&r2=1774871&view=diff
> =====================================================================
> =========
> --- sling/trunk/tooling/jenkins/create_jobs.groovy (original)
> +++ sling/trunk/tooling/jenkins/create_jobs.groovy Sun Dec 18
> 10:15:02 2016
> @@ -32,7 +32,7 @@ def modules = [
> �����],
> �����[
> ���������location: 'bundles/commons/log-webconsole'
> -����],����
> +����],
> �����[
> ���������location: 'bundles/commons/logservice'
> �����],
> @@ -593,24 +593,24 @@ def modules = [
> �����[
> ���������location: "installer/providers/file"
> �����],
> -����[
> -��������location: 'karaf/org.apache.sling.karaf-distribution'
> -����],
> -����[
> -��������location: 'karaf/org.apache.sling.karaf-features'
> -����],
> -����[
> -��������location: 'karaf/org.apache.sling.karaf-integration-tests'
> -����],
> -����[
> -��������location: 'karaf/org.apache.sling.karaf-launchpad-oak-tar-
> integration-tests'
> -����],
> -����[
> -��������location: 'karaf/org.apache.sling.karaf-repoinit'
> -����],
> -����[
> -��������location: 'karaf/org.apache.sling.karaf-configs'
> -����],
> +//����[
> +//��������location: 'karaf/org.apache.sling.karaf-distribution'
> +//����],
> +//����[
> +//��������location: 'karaf/org.apache.sling.karaf-features'
> +//����],
> +//����[
> +//��������location: 'karaf/org.apache.sling.karaf-integration-tests'
> +//����],
> +//����[
> +//��������location: 'karaf/org.apache.sling.karaf-launchpad-oak-tar-
> integration-tests'
> +//����],
> +//����[
> +//��������location: 'karaf/org.apache.sling.karaf-repoinit'
> +//����],
> +//����[
> +//��������location: 'karaf/org.apache.sling.karaf-configs'
> +//����],
> �����[
> ���������location: 'launchpad/api',
> ���������jdks: ["1.8"]
> @@ -915,7 +915,7 @@ for more details</p>''')
> �������������// job is triggered first and we may end up with a
> �������������// mix of Java 7 and Java 8 artifacts for projects which
> �������������// use these 2 versions
> -������������def extraGoalsParams = module.extraGoalsParams ?: ""�
> +������������def extraGoalsParams = module.extraGoalsParams ?: ""
> �������������goals( (deploy ? "-U clean deploy" : "-U clean verify")
> + " " + extraGoalsParams)
> �
> �������������publishers {
> 
>