You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/29 09:55:42 UTC
[GitHub] [tvm] wrongtest opened a new pull request, #11179: [TVMScript] Support round-trip for T.Ptr
wrongtest opened a new pull request, #11179:
URL: https://github.com/apache/tvm/pull/11179
cc @Hzfengsy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #11179: [TVMScript] Support round-trip for T.Ptr
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11179:
URL: https://github.com/apache/tvm/pull/11179#issuecomment-1113559579
We might have to suppress pug lake when it reports such error, because it expects “global” as a type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy commented on pull request #11179: [TVMScript] Support round-trip for T.Ptr
Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on PR #11179:
URL: https://github.com/apache/tvm/pull/11179#issuecomment-1113134833
cc @junrushao1994 @yelite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest commented on pull request #11179: [TVMScript] Support round-trip for T.Ptr
Posted by GitBox <gi...@apache.org>.
wrongtest commented on PR #11179:
URL: https://github.com/apache/tvm/pull/11179#issuecomment-1113160931
BTW, pyflake will complain `F722 syntax error in forward annotation 'global'`, so it would be better to omit the scope field for global ptr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yelite commented on pull request #11179: [TVMScript] Support round-trip for T.Ptr
Posted by GitBox <gi...@apache.org>.
yelite commented on PR #11179:
URL: https://github.com/apache/tvm/pull/11179#issuecomment-1113694091
This looks good to me!
I've been thinking about how to avoid lint errors from treating string as forward type annotation and have some idea. I opened #11192 for discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #11179: [TVMScript] Support round-trip for T.Ptr
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11179:
URL: https://github.com/apache/tvm/pull/11179#issuecomment-1113642253
@yelite would be good to have your review too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest merged pull request #11179: [TVMScript] Support round-trip for T.Ptr
Posted by GitBox <gi...@apache.org>.
wrongtest merged PR #11179:
URL: https://github.com/apache/tvm/pull/11179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org