[jira] [Commented] (REEF-603) Resolving duplicate entries in Configurations.Merge

["Markus Weimer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/REEF-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702210#comment-14702210 ] 

Markus Weimer commented on REEF-603:
------------------------------------

+1

If the conflict can be resolved because both {{IConfiguration}} instances contain the exact same binding for the same key, I think there is no harm in ignoring it.

> Resolving duplicate entries in Configurations.Merge
> ---------------------------------------------------
>
>                 Key: REEF-603
>                 URL: https://issues.apache.org/jira/browse/REEF-603
>             Project: REEF
>          Issue Type: Bug
>          Components: REEF.NET
>         Environment: C#
>            Reporter: Dhruv Mahajan
>
> Currently in Configurations.Merge function say we want to merge config1 and config2 and say there are duplicate entries in the two configs (means both key:interface or named parameter being binded and value:means value to which it is binded, are same), the function still throws the error while ideal situation is to just do a dedupe and give merged or union of the two.
> This seems like a trivial fix and should be done. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)