You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2023/10/28 11:44:28 UTC

[PR] [SPARK-45481][SQL][FOLLOWUP] Add `lowerCaseName` for `ParquetCompressionCodec`. [spark]

beliefer opened a new pull request, #43571:
URL: https://github.com/apache/spark/pull/43571

   ### What changes were proposed in this pull request?
   https://github.com/apache/spark/pull/43308 introduces a mapper for parquet compression codecs.
   There are many place call `toLowerCase(Locale.ROOT)` to get the lower case name of parquet compression codecs.
   
   
   ### Why are the changes needed?
   Add `lowerCaseName` for `ParquetCompressionCodec`.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   New class.
   
   
   ### How was this patch tested?
   Exists test cases.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   'No'.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45481][SQL][FOLLOWUP] Add `lowerCaseName` for `ParquetCompressionCodec`. [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43571:
URL: https://github.com/apache/spark/pull/43571#issuecomment-1785818454

   Merged to master. Thank you, @beliefer .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45481][SQL][FOLLOWUP] Add `lowerCaseName` for `ParquetCompressionCodec`. [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43571: [SPARK-45481][SQL][FOLLOWUP] Add `lowerCaseName` for `ParquetCompressionCodec`.
URL: https://github.com/apache/spark/pull/43571


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45481][SQL][FOLLOWUP] Add `lowerCaseName` for `ParquetCompressionCodec`. [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #43571:
URL: https://github.com/apache/spark/pull/43571#issuecomment-1787018903

   @dongjoon-hyun @LuciferYang Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org