You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/06 17:30:53 UTC

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh

liuguo09 opened a new pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/461
 
 
   Signed-off-by: liuhaitao <li...@xiaomi.com>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh

Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/461#issuecomment-596031932
 
 
   ok, thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo merged pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh

Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/461
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/461#issuecomment-595885959
 
 
   > one config of arm07 build breaks, it should be fixed to pass check build : (
   
   That is not relevant to this change, is it?  That is a SAMA5Dx and has nothing to do with LittleFS.  I will continue with the merge.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh

Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #461: fs/littlefs: correct some code format in lfs.h by running checkpatch.sh
URL: https://github.com/apache/incubator-nuttx/pull/461#issuecomment-595879809
 
 
   one config of arm07 build breaks, it should be fixed to pass check build : (
   
   ====================================================================================
   Configuration/Tool: sama5d3x-ek/nsh,CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
   ------------------------------------------------------------------------------------
     Configuring...
     Copy files
     Select CONFIG_HOST_LINUX=y
     Refreshing...
     Disabling CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL
     Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
     Refreshing...
     Building NuttX...
   ------------------------------------------------------------------------------------
   chip/sam_memories.c: In function 'periphb_physregaddr':
   chip/sam_memories.c:86:5: warning: "SAM_PERIPHB_PSECTION" is not defined, evaluates to 0 [-Wundef]
      86 | #if SAM_PERIPHB_PSECTION != SAM_PERIPHB_VSECTION
         |     ^~~~~~~~~~~~~~~~~~~~
   chip/sam_memories.c:95:10: error: 'SAM_PERIPHB_PSECTION' undeclared (first use in this function); did you mean 'SAM_PERIPHA_PSECTION'?
      95 |   return SAM_PERIPHB_PSECTION + sectoffset;
         |          ^~~~~~~~~~~~~~~~~~~~
         |          SAM_PERIPHA_PSECTION
   chip/sam_memories.c:95:10: note: each undeclared identifier is reported only once for each function it appears in
   chip/sam_memories.c: In function 'sysc_physregaddr':
   chip/sam_memories.c:149:5: warning: "SAM_SYSC_PSECTION" is not defined, evaluates to 0 [-Wundef]
     149 | #if SAM_SYSC_PSECTION != SAM_SYSC_VSECTION
         |     ^~~~~~~~~~~~~~~~~
   chip/sam_memories.c:158:10: error: 'SAM_SYSC_PSECTION' undeclared (first use in this function); did you mean 'SAM_SYSC_VSECTION'?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services