You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2014/06/03 03:16:45 UTC
Review Request 22170: analyze table T compute statistics for columns;
will now compute stats for all columns.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22170/
-----------------------------------------------------------
Review request for hive and Prasanth_J.
Bugs: HIVE-7168
https://issues.apache.org/jira/browse/HIVE-7168
Repository: hive-git
Description
-------
analyze table T compute statistics for columns; will now compute stats for all columns.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 5b77e6f
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6d958fd
ql/src/test/queries/clientpositive/columnstats_partlvl.q 9dfe8ff
ql/src/test/queries/clientpositive/columnstats_tbllvl.q 170fbc5
ql/src/test/results/clientpositive/columnstats_partlvl.q.out d91be8d
ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 3d3d0e2
Diff: https://reviews.apache.org/r/22170/diff/
Testing
-------
Added new tests.
Thanks,
Ashutosh Chauhan
Re: Review Request 22170: analyze table T compute statistics for columns;
will now compute stats for all columns.
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22170/#review44974
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanth_J
On June 6, 2014, 4:30 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22170/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 4:30 p.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Bugs: HIVE-7168
> https://issues.apache.org/jira/browse/HIVE-7168
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> analyze table T compute statistics for columns; will now compute stats for all columns.
>
>
> Diffs
> -----
>
> metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionColumnStatistics.java 1245d80
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 5b77e6f
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6d958fd
> ql/src/test/queries/clientpositive/columnstats_partlvl.q 9dfe8ff
> ql/src/test/queries/clientpositive/columnstats_tbllvl.q 170fbc5
> ql/src/test/results/clientpositive/columnstats_partlvl.q.out d91be8d
> ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 3d3d0e2
> ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 03b536f
>
> Diff: https://reviews.apache.org/r/22170/diff/
>
>
> Testing
> -------
>
> Added new tests.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 22170: analyze table T compute statistics for columns;
will now compute stats for all columns.
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22170/
-----------------------------------------------------------
(Updated June 6, 2014, 4:30 p.m.)
Review request for hive and Prasanth_J.
Changes
-------
Fixed last failing test.
Bugs: HIVE-7168
https://issues.apache.org/jira/browse/HIVE-7168
Repository: hive-git
Description
-------
analyze table T compute statistics for columns; will now compute stats for all columns.
Diffs (updated)
-----
metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionColumnStatistics.java 1245d80
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 5b77e6f
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6d958fd
ql/src/test/queries/clientpositive/columnstats_partlvl.q 9dfe8ff
ql/src/test/queries/clientpositive/columnstats_tbllvl.q 170fbc5
ql/src/test/results/clientpositive/columnstats_partlvl.q.out d91be8d
ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 3d3d0e2
ql/src/test/results/clientpositive/display_colstats_tbllvl.q.out 03b536f
Diff: https://reviews.apache.org/r/22170/diff/
Testing
-------
Added new tests.
Thanks,
Ashutosh Chauhan
Re: Review Request 22170: analyze table T compute statistics for columns;
will now compute stats for all columns.
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22170/
-----------------------------------------------------------
(Updated June 5, 2014, 7:37 p.m.)
Review request for hive and Prasanth_J.
Changes
-------
Incorporated Prashanth's suggestion for displaying column stats.
Bugs: HIVE-7168
https://issues.apache.org/jira/browse/HIVE-7168
Repository: hive-git
Description
-------
analyze table T compute statistics for columns; will now compute stats for all columns.
Diffs (updated)
-----
metastore/src/model/org/apache/hadoop/hive/metastore/model/MPartitionColumnStatistics.java 1245d80
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 5b77e6f
ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6d958fd
ql/src/test/queries/clientpositive/columnstats_partlvl.q 9dfe8ff
ql/src/test/queries/clientpositive/columnstats_tbllvl.q 170fbc5
ql/src/test/results/clientpositive/columnstats_partlvl.q.out d91be8d
ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 3d3d0e2
Diff: https://reviews.apache.org/r/22170/diff/
Testing
-------
Added new tests.
Thanks,
Ashutosh Chauhan
Re: Review Request 22170: analyze table T compute statistics for columns;
will now compute stats for all columns.
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22170/#review44583
-----------------------------------------------------------
ql/src/test/queries/clientpositive/columnstats_tbllvl.q
<https://reviews.apache.org/r/22170/#comment79003>
Now that HIVE-7050 is committed to trunk, can you extend this test case to display column stats? Just a sanity check for this analyze statement.
- Prasanth_J
On June 3, 2014, 1:16 a.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22170/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 1:16 a.m.)
>
>
> Review request for hive and Prasanth_J.
>
>
> Bugs: HIVE-7168
> https://issues.apache.org/jira/browse/HIVE-7168
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> analyze table T compute statistics for columns; will now compute stats for all columns.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 5b77e6f
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6d958fd
> ql/src/test/queries/clientpositive/columnstats_partlvl.q 9dfe8ff
> ql/src/test/queries/clientpositive/columnstats_tbllvl.q 170fbc5
> ql/src/test/results/clientpositive/columnstats_partlvl.q.out d91be8d
> ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 3d3d0e2
>
> Diff: https://reviews.apache.org/r/22170/diff/
>
>
> Testing
> -------
>
> Added new tests.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>