You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datalab.apache.org by dg...@apache.org on 2020/11/09 13:39:53 UTC
[incubator-datalab] branch DATALAB-2149 created (now 98f74c2)
This is an automated email from the ASF dual-hosted git repository.
dgnatyshyn pushed a change to branch DATALAB-2149
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git.
at 98f74c2 [DATALAB-2149]: Fixed issue with filter on library page, preloader on bucket browser
This branch includes the following new commits:
new 98f74c2 [DATALAB-2149]: Fixed issue with filter on library page, preloader on bucket browser
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org
[incubator-datalab] 01/01: [DATALAB-2149]: Fixed issue with filter
on library page, preloader on bucket browser
Posted by dg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
dgnatyshyn pushed a commit to branch DATALAB-2149
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git
commit 98f74c259697017e1e550227268e5a420b3f8fdf
Author: Dmytro_Gnatyshyn <di...@ukr.net>
AuthorDate: Mon Nov 9 15:39:06 2020 +0200
[DATALAB-2149]: Fixed issue with filter on library page, preloader on bucket browser
---
.../bucket-confirmation-dialog.component.scss | 7 --
.../install-libraries.component.html | 2 +-
.../install-libraries.component.scss | 124 +++++++--------------
.../install-libraries.component.ts | 4 +-
.../confirmation-dialog.component.scss | 7 --
5 files changed, 42 insertions(+), 102 deletions(-)
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/bucket-browser/bucket-confirmation-dialog/bucket-confirmation-dialog.component.scss b/services/self-service/src/main/resources/webapp/src/app/resources/bucket-browser/bucket-confirmation-dialog/bucket-confirmation-dialog.component.scss
index 4d7ab0c..e739c5b 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/bucket-browser/bucket-confirmation-dialog/bucket-confirmation-dialog.component.scss
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/bucket-browser/bucket-confirmation-dialog/bucket-confirmation-dialog.component.scss
@@ -67,13 +67,6 @@
padding-top: 11px;
}
}
- .empty-list {
- display: flex;
- width: 100%;
- justify-content: center;
- color: #35afd5;
- padding: 15px;
- }
.list-header {
border-top: 1px solid #edf1f5;
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
index c3da0d0..41f9246 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.html
@@ -292,7 +292,7 @@
</multi-select-dropdown>
</th>
<ng-container matColumnDef="action-filter" stickyEnd>
- <th mat-header-cell>
+ <th>
<div class="filter-actions actions">
<button mat-icon-button class="btn reset" (click)="resetFilterConfigurations()" [disabled]="!isFilterSelected">
<i class="material-icons">close</i>
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss
index 3c60199..bf7bb4c 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.scss
@@ -42,26 +42,6 @@
}
}
-.loading-block {
- height: 40%;
- display: flex;
- justify-content: center;
-
- .uploading {
- padding-top: 200px;
- flex-direction: column;
- align-items: center;
- align-self: center;
- list-style: none;
- display: flex;
-
- p {
- font-size: 16px;
- ;
- }
- }
-}
-
.info {
height: 30%;
}
@@ -92,7 +72,9 @@
.mat-list-item {
height: auto !important;
font-family: "Open Sans", sans-serif;
- font-weight: 400;
+ color: #718ba6 !important;
+ font-size: 13px !important;
+ font-weight: 300;
.mat-list-item-content {
height: auto !important;
@@ -135,6 +117,30 @@
padding: 3px;
}
}
+
+ .loading-block {
+ height: 40%;
+ display: flex;
+ justify-content: center;
+
+ .uploading {
+ padding-top: 200px;
+ flex-direction: column;
+ align-items: center;
+ align-self: center;
+ list-style: none;
+ display: flex;
+
+ p {
+ font-size: 16px;
+ ;
+ }
+ }
+ }
+
+ .list-header{
+ line-height: 40px;
+ }
}
.list-item{
@@ -154,40 +160,10 @@
width: 30%;
}
-.scrolling-content.delete-list {
- max-height: 200px;
- overflow-y: auto;
-}
-
-.empty-list {
- display: flex;
- width: 100%;
- justify-content: center;
- color: #35afd5;
- padding: 14px;
-}
-
ul.resources{
padding-left: 10px;
}
-.dependency-list-header {
- color: #577289;
- width: 100%;
- padding: 15px 0 5px 0;
- font-weight: 600;
-}
-
-.add-icon{
- cursor: pointer;
- position: absolute;
- top: -13px;
- right: 10px;
- .mat-icon{
- font-size: 24px;
- }
-}
-
.search-box {
display: flex;
padding: 20px 25px 10px;
@@ -324,12 +300,6 @@ ul.resources{
}
}
-.mat-list-item {
- color: #718ba6 !important;
- font-size: 13px !important;
- font-weight: 300;
-}
-
mat-chip.mat-chip:not(.mat-basic-chip) {
margin: 2px !important;
background-color: rgba(47, 174, 215, .2) !important;
@@ -338,12 +308,6 @@ mat-chip.mat-chip:not(.mat-basic-chip) {
/* Tab info */
-.install-libraries{
- .list-header{
- line-height: 40px;
- }
-}
-
.mat-dialog-container {
position: relative;
}
@@ -499,22 +463,6 @@ mat-chip.mat-chip:not(.mat-basic-chip) {
}
}
-.reinstall-all {
- margin: 10px 5px;
- position: fixed;
- right: 0;
- bottom: 0;
-}
-
-.mat-tab-labels .mat-ink-bar {
- background-color: #35afd5;
-}
-
-.dropdown-multiselect button span {
- padding-top: 7px;
- padding-bottom: 3px;
-}
-
.mat-dialog-container.mat-dialog-container .install-libraries#dialog-box {
.mat-header-cell{
padding: 0;
@@ -540,15 +488,21 @@ mat-chip.mat-chip:not(.mat-basic-chip) {
}
}
-.install-libraries .dropdown-multiselect .list-menu li {
-
- a{
- font-size: 13px;
+.install-libraries .dropdown-multiselect {
+ .list-menu li {
+ a {
+ font-size: 13px;
- &.list-item{
- color: #4a5c89 !important;
+ &.list-item {
+ color: #4a5c89 !important;
+ }
}
}
+
+ button span {
+ padding-top: 7px;
+ padding-bottom: 3px;
+ }
}
.error-message{
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
index 719a2a0..72d6563 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/exploratory/install-libraries/install-libraries.component.ts
@@ -194,7 +194,6 @@ export class InstallLibrariesComponent implements OnInit, OnDestroy {
? this.model.computational_name = this.destination.name
: this.model.computational_name = null;
this.resetDialog();
- // this.getInstalledLibsByResource();
this.libSearch.disable();
}
this.filterList();
@@ -288,6 +287,7 @@ export class InstallLibrariesComponent implements OnInit, OnDestroy {
() => {
this.getInstalledLibrariesList(true);
this.changeDetector.detectChanges();
+
this.selectorsReset();
},
this.librariesInstallationService);
@@ -426,7 +426,7 @@ export class InstallLibrariesComponent implements OnInit, OnDestroy {
}
private getMatchedLibs() {
- if (this.lib.name.length < 2) {
+ if (!this.lib.name || this.lib.name.length < 2) {
return;
}
this.model.getLibrariesList(this.group, this.lib.name.toLowerCase())
diff --git a/services/self-service/src/main/resources/webapp/src/app/shared/modal-dialog/confirmation-dialog/confirmation-dialog.component.scss b/services/self-service/src/main/resources/webapp/src/app/shared/modal-dialog/confirmation-dialog/confirmation-dialog.component.scss
index 1764dfb..1022888 100644
--- a/services/self-service/src/main/resources/webapp/src/app/shared/modal-dialog/confirmation-dialog/confirmation-dialog.component.scss
+++ b/services/self-service/src/main/resources/webapp/src/app/shared/modal-dialog/confirmation-dialog/confirmation-dialog.component.scss
@@ -49,13 +49,6 @@
overflow-y: auto;
}
}
- .empty-list {
- display: flex;
- width: 100%;
- justify-content: center;
- color: #35afd5;
- padding: 15px;
- }
.list-header {
border-top: 1px solid #edf1f5;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org