You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by dz...@apache.org on 2021/10/30 09:52:02 UTC

[drill-site] 01/03: Update sourceParameters example for pg to encourage minimumIdle = 0.

This is an automated email from the ASF dual-hosted git repository.

dzamo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/drill-site.git

commit 0b26ee8be6b965011f312a41349efe861db95da4
Author: James Turton <ja...@somecomputer.xyz>
AuthorDate: Fri Oct 22 11:14:32 2021 +0200

    Update sourceParameters example for pg to encourage minimumIdle = 0.
---
 .../plugins/080-rdbms-storage-plugin.md                | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/_docs/en/connect-a-data-source/plugins/080-rdbms-storage-plugin.md b/_docs/en/connect-a-data-source/plugins/080-rdbms-storage-plugin.md
index 8832579..05c0f3e 100644
--- a/_docs/en/connect-a-data-source/plugins/080-rdbms-storage-plugin.md
+++ b/_docs/en/connect-a-data-source/plugins/080-rdbms-storage-plugin.md
@@ -10,18 +10,18 @@ As with any source, Drill supports joins within and between all systems. Drill a
 ## Using the RDBMS Storage Plugin
 
 Drill is designed to work with any relational datastore that provides a JDBC driver. Drill is actively tested with
- Postgres, MySQL, Oracle, MSSQL, Apache Derby and H2. For each system, you will follow three basic steps for setup:
+ PostgreSQL, MySQL, Oracle, MSSQL, Apache Derby and H2. For each system, you will follow three basic steps for setup:
 
   1. [Install Drill]({{ site.baseurl }}/docs/installing-drill-in-embedded-mode), if you do not already have it installed.
   2. Copy your database's JDBC driver into the `jars/3rdparty` directory. (You'll need to do this on every node.)  
   3. Restart Drill. See [Starting Drill in Distributed Mode]({{site.baseurl}}/docs/starting-drill-in-distributed-mode/).
-  4. Add a new storage configuration to Drill through the Web UI. Example configurations for [Oracle](#example-oracle-configuration), [SQL Server](#example-sql-server-configuration), [MySQL](#example-mysql-configuration) and [Postgres](#example-postgres-configuration) are provided below.
+  4. Add a new storage configuration to Drill through the Web UI. Example configurations for [Oracle](#example-oracle-configuration), [SQL Server](#example-sql-server-configuration), [MySQL](#example-mysql-configuration) and [PostgreSQL](#example-postgres-configuration) are provided below.
 
 ## Setting data source parameters in the storage plugin configuration
 
 **Introduced in release:** 1.18
 
-A JDBC storage plugin configuration property `sourceParameters` was introduced to allow setting data source parameters described in [HikariCP](https://github.com/brettwooldridge/HikariCP#configuration-knobs-baby).  Parameters names with incorrect naming and parameter values which are of incorrect data type or illegal will cause the storage plugin to fail to start.  See the [Example of Postgres Configuration with `sourceParameters` configuration property](#example-of-postgres-configuratio [...]
+A JDBC storage plugin configuration property `sourceParameters` was introduced to allow setting data source parameters described in [HikariCP](https://github.com/brettwooldridge/HikariCP#configuration-knobs-baby).  Parameters names with incorrect naming and parameter values which are of incorrect data type or illegal will cause the storage plugin to fail to start.  See the [Example of PostgreSQL Configuration with `sourceParameters` configuration property](#example-of-postgres-configurat [...]
 
 ### Example: Working with MySQL
 
@@ -111,12 +111,12 @@ For MySQL, Drill has been tested with MySQL's [mysql-connector-java-5.1.37-bin.j
 }  
 ```
 
-### Example Postgres Configuration
+### Example PostgreSQL Configuration
 
-Drill is tested with the Postgres driver version [42.2.11](https://mvnrepository.com/artifact/org.postgresql/postgresql) (any recent driver should work).
+Drill is tested with the PostgreSQL driver version [42.2.11](https://mvnrepository.com/artifact/org.postgresql/postgresql) (any recent driver should work).
  Download and copy this driver jar to the `jars/3rdparty` folder on all nodes.
 
-{% include startnote.html %}You'll need to provide a database name as part of your JDBC connection string for Drill to correctly expose Postgres tables.{% include endnote.html %}
+{% include startnote.html %}You'll need to provide a database name as part of your JDBC connection string for Drill to correctly expose PostgreSQL tables.{% include endnote.html %}
 
 ```json
 {
@@ -155,7 +155,7 @@ You may need to qualify a table name with a schema name for Drill to return data
        | 2    | 1.2.3.5 |
        |------|---------|
 
-### Example of Postgres Configuration with `sourceParameters` configuration property
+### Example of PostgreSQL Configuration with `sourceParameters` configuration property
 ```json
 {
   "type": "jdbc",
@@ -165,8 +165,8 @@ You may need to qualify a table name with a schema name for Drill to return data
   "username": "user",
   "password": "password",
   "sourceParameters": {
-    "minimumIdle": 5,
-    "autoCommit": false,
+    "minimumIdle": 0,
+    "autoCommit": true,
     "connectionTestQuery": "select version() as postgresql_version",
     "dataSource.cachePrepStmts": true,
     "dataSource.prepStmtCacheSize": 250