You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/06/06 22:28:40 UTC
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Hello Vuk Ercegovac,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10626
to review the following change.
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
IMPALA-7128 (part 2): add an interface for data sources
This changes most of the usage of DataSource and DataSourceTable to use
interfaces instead of implementation classes. There are still various
usages of the implementation for functionality like creating and
dropping data sources. We'll address those as part of IMPALA-7131 at a
later date.
Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/catalog/DataSource.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSource.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
13 files changed, 99 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/10626/1
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 21:01:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10626
to look at the new patch set (#2).
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
IMPALA-7128 (part 2): add an interface for data sources
This changes most of the usage of DataSource and DataSourceTable to use
interfaces instead of implementation classes. There are still various
usages of the implementation for functionality like creating and
dropping data sources. We'll address those as part of IMPALA-7131 at a
later date.
Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/catalog/DataSource.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSource.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
13 files changed, 99 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/10626/2
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2673/
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:14:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10626/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10626/2//COMMIT_MSG@12
PS2, Line 12: IMPALA-7131
pls mark these with todo's that reference this jira.
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@42
PS2, Line 42: Represents a table backed by an external data source.
pull this part up into the interface.
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/FeDataSource.java
File fe/src/main/java/org/apache/impala/catalog/FeDataSource.java:
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/FeDataSource.java@21
PS2, Line 21: * Interface for interacting with data sources from the frontend.
nit: use consistent phrasing with the other interfaces
"Frontend interface for interacting with data sources."
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Jun 2018 18:01:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10626
to look at the new patch set (#3).
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
IMPALA-7128 (part 2): add an interface for data sources
This changes most of the usage of DataSource and DataSourceTable to use
interfaces instead of implementation classes. There are still various
usages of the implementation for functionality like creating and
dropping data sources. We'll address those as part of IMPALA-7131 at a
later date.
Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/catalog/DataSource.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSource.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
14 files changed, 110 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/10626/3
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
IMPALA-7128 (part 2): add an interface for data sources
This changes most of the usage of DataSource and DataSourceTable to use
interfaces instead of implementation classes. There are still various
usages of the implementation for functionality like creating and
dropping data sources. We'll address those as part of IMPALA-7131 at a
later date.
Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Reviewed-on: http://gerrit.cloudera.org:8080/10626
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableStmt.java
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/catalog/DataSource.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSource.java
A fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/main/java/org/apache/impala/service/JniFrontend.java
14 files changed, 110 insertions(+), 32 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 7
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:14:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 6
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 23:38:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 17:08:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10626/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10626/2//COMMIT_MSG@12
PS2, Line 12: IMPALA-7131
> pls mark these with todo's that reference this jira.
Done
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
File fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java:
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java@42
PS2, Line 42: Represents a table backed by an external data source.
> pull this part up into the interface.
Done
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/FeDataSource.java
File fe/src/main/java/org/apache/impala/catalog/FeDataSource.java:
http://gerrit.cloudera.org:8080/#/c/10626/2/fe/src/main/java/org/apache/impala/catalog/FeDataSource.java@21
PS2, Line 21: * Interface for interacting with data sources from the frontend.
> nit: use consistent phrasing with the other interfaces
Done
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 23:34:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jun 2018 04:17:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 5
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:07:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7128 (part 2): add an interface for data sources
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10626 )
Change subject: IMPALA-7128 (part 2): add an interface for data sources
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2651/
--
To view, visit http://gerrit.cloudera.org:8080/10626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe704197dc2ad7c09b8340865f17567096aa630e
Gerrit-Change-Number: 10626
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Jun 2018 01:09:08 +0000
Gerrit-HasComments: No