You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2014/10/17 17:48:32 UTC

[Bug 57107] New: Patch proposal: Add DAV verbs to HTTP Sampler

https://issues.apache.org/bugzilla/show_bug.cgi?id=57107

            Bug ID: 57107
           Summary: Patch proposal: Add DAV verbs to HTTP Sampler
           Product: JMeter
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: HTTP
          Assignee: issues@jmeter.apache.org
          Reporter: apache@famille-jung.fr

Created attachment 32121
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32121&action=edit
dav_patch.diff. Implements HTTP DAV verbs

The following patch adds the following verbs in HTTP Proxy Recorder / HTTP
Sampler:

PROPFIND
PROPPATCH
MKCOL
COPY
MOVE
LOCK
UNLOCK

I have been able to test PROPFIND, PROPPATCH, MKCOL, COPY, MOVE mixed with
DELETE, PUT & HEAD (Recording and replaying ownCloud client trafic to ownCloud
server)

For the moment implementation is only in HTTPHC4Impl.java, neither in
HTTPHC3Impl.java nor in HTTPJavaImpl.java

I would like to know if you are interested by this patch? In this case, I will
update it with modified HTTPHC3Impl.java. Not sure HTTPJavaImpl.java is
required as I have seen unimplemented methods in HTTPJavaImpl.java (PATCH as
far as I can remember).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57107] Patch proposal: Add DAV verbs to HTTP Sampler

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57107

Philippe Jung <ap...@famille-jung.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.11

--- Comment #1 from Philippe Jung <ap...@famille-jung.fr> ---
Patch is based on svn trunk

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57107] Patch proposal: Add DAV verbs to HTTP Sampler

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57107

--- Comment #2 from Sebb <se...@apache.org> ---
Thanks!

Patch looks generally good, though I wonder if the Webdav method checking could
be done in a shared utility method.

I don't think there is any need to implement the code for the HC3 or Java
implementations.

However some extra documentation is needed for component_reference.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57107] Patch proposal: Add DAV verbs to HTTP Sampler

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57107

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
           Hardware|PC                          |All
                 OS|Linux                       |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57107] Patch proposal: Add DAV verbs to HTTP Sampler

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57107

Philippe Jung <ap...@famille-jung.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32121|0                           |1
        is obsolete|                            |

--- Comment #3 from Philippe Jung <ap...@famille-jung.fr> ---
Created attachment 32123
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=32123&action=edit
dav_patch_v2.diff - Implements HTTP DAV verbs - new version

- Class HttpWebdav.java extracted from HTTPHC4Impl.java to
org.apache.jmeter.protocol.http.sampler
- added isWebdavMethod in HttpWebdav class
- updated other files to use isWebdavMethod
- updated xdocs/usermanual/component_reference.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57107] Patch proposal: Add DAV verbs to HTTP Sampler

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57107

--- Comment #5 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Thanks a lot for your great contribution !
A tutorial or blog entry would be welcome :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 57107] Patch proposal: Add DAV verbs to HTTP Sampler

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=57107

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Date: Sat Oct 18 13:09:16 2014
New Revision: 1632785

URL: http://svn.apache.org/r1632785
Log:
Bug 57107 - Patch proposal: Add DAV verbs to HTTP Sampler
Bugzilla Id: 57107

Added:
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HttpWebdav.java
  (with props)
Modified:
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSampleResult.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
   
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/HTTPConstantsInterface.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/component_reference.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.