You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/05/08 02:53:50 UTC

Re: Review Request 21182: Refactored ZooKeeperImpl into ZooKeeperProcess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21182/
-----------------------------------------------------------

(Updated May 8, 2014, 12:53 a.m.)


Review request for mesos and Jiang Yan Xu.


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  src/zookeeper/zookeeper.hpp 242e2deffb2470a588b78ab3ede232dfc4dbe01e 
  src/zookeeper/zookeeper.cpp e3b65e4a2dbe685d8254fe3d11671d6df9c2b176 

Diff: https://reviews.apache.org/r/21182/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request 21182: Refactored ZooKeeperImpl into ZooKeeperProcess.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21182/#review42523
-----------------------------------------------------------

Ship it!


I have drawn out the call sequences for the "recursion via .then" in create() and it looks good!
Libprocessifying ZooKeeperImpl -> ZooKeeperProcess solves two problems we have:
1. Watcher events coming in too soon during ZooKeeper object construction.
2. Watcher events coming in too late during (racing with) Zookeeper object destruction (due to local timeout)

This patch looks great to me!

- Jiang Yan Xu


On May 7, 2014, 5:56 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21182/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 5:56 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1318
>     https://issues.apache.org/jira/browse/MESOS-1318
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Yan Xu and I paired on this. See https://issues.apache.org/jira/browse/MESOS-1318 for more details.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/zookeeper.hpp 242e2deffb2470a588b78ab3ede232dfc4dbe01e 
>   src/zookeeper/zookeeper.cpp e3b65e4a2dbe685d8254fe3d11671d6df9c2b176 
> 
> Diff: https://reviews.apache.org/r/21182/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 21182: Refactored ZooKeeperImpl into ZooKeeperProcess.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21182/#review42515
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On May 8, 2014, 12:56 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21182/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 12:56 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-1318
>     https://issues.apache.org/jira/browse/MESOS-1318
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Yan Xu and I paired on this. See https://issues.apache.org/jira/browse/MESOS-1318 for more details.
> 
> 
> Diffs
> -----
> 
>   src/zookeeper/zookeeper.hpp 242e2deffb2470a588b78ab3ede232dfc4dbe01e 
>   src/zookeeper/zookeeper.cpp e3b65e4a2dbe685d8254fe3d11671d6df9c2b176 
> 
> Diff: https://reviews.apache.org/r/21182/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request 21182: Refactored ZooKeeperImpl into ZooKeeperProcess.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21182/
-----------------------------------------------------------

(Updated May 8, 2014, 12:56 a.m.)


Review request for mesos, Vinod Kone and Jiang Yan Xu.


Bugs: MESOS-1318
    https://issues.apache.org/jira/browse/MESOS-1318


Repository: mesos-git


Description (updated)
-------

Yan Xu and I paired on this. See https://issues.apache.org/jira/browse/MESOS-1318 for more details.


Diffs
-----

  src/zookeeper/zookeeper.hpp 242e2deffb2470a588b78ab3ede232dfc4dbe01e 
  src/zookeeper/zookeeper.cpp e3b65e4a2dbe685d8254fe3d11671d6df9c2b176 

Diff: https://reviews.apache.org/r/21182/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request 21182: Refactored ZooKeeperImpl into ZooKeeperProcess.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21182/
-----------------------------------------------------------

(Updated May 8, 2014, 12:55 a.m.)


Review request for mesos, Vinod Kone and Jiang Yan Xu.


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/zookeeper/zookeeper.hpp 242e2deffb2470a588b78ab3ede232dfc4dbe01e 
  src/zookeeper/zookeeper.cpp e3b65e4a2dbe685d8254fe3d11671d6df9c2b176 

Diff: https://reviews.apache.org/r/21182/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman