Re: [PR] Cleanup logical optimizer rules. [datafusion]

["Blizzara (via GitHub)" <gi...@apache.org>]

Blizzara commented on code in PR #7919:
URL: https://github.com/apache/datafusion/pull/7919#discussion_r2101973479


##########
datafusion/common/src/dfschema.rs:
##########
@@ -444,6 +444,14 @@ impl DFSchema {
                         .zip(iter2)
                         .all(|((t1, f1), (t2, f2))| t1 == t2 && Self::field_is_semantically_equal(f1, f2))
             }
+            (

Review Comment:
   @mustafasrepo I'm curious in case you remember, why did you add these? It feels to me like decimals with different precision/scale are inherently not the same datatype.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org