You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/13 06:39:29 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39551: [SPARK-42047][SPARK-41900][CONNECT][PYTHON] Literal should support numpy datatypes
zhengruifeng opened a new pull request, #39551:
URL: https://github.com/apache/spark/pull/39551
### What changes were proposed in this pull request?
Make `Literal` support numpy datatypes
### Why are the changes needed?
for parity
### Does this PR introduce _any_ user-facing change?
yes
### How was this patch tested?
enabled tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #39551: [SPARK-42047][SPARK-41900][CONNECT][PYTHON] Literal should support Numpy datatypes
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39551: [SPARK-42047][SPARK-41900][CONNECT][PYTHON] Literal should support Numpy datatypes
URL: https://github.com/apache/spark/pull/39551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39551: [SPARK-42047][SPARK-41900][CONNECT][PYTHON] Literal should support Numpy datatypes
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39551:
URL: https://github.com/apache/spark/pull/39551#issuecomment-1382647022
merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39551: [SPARK-42047][SPARK-41900][CONNECT][PYTHON] Literal should support numpy datatypes
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39551:
URL: https://github.com/apache/spark/pull/39551#discussion_r1068985761
##########
python/pyspark/sql/tests/connect/test_parity_functions.py:
##########
@@ -59,7 +59,7 @@ def test_inverse_trig_functions(self):
def test_lit_list(self):
super().test_lit_list()
- # TODO(SPARK-41900): support Data Type int8
+ # TODO(SPARK-41283): Different column names of `lit(np.int8(1))`
Review Comment:
It's a bit weird that the column names are different even if I use the `Cast` in Connect:
```
- [('1', 'tinyint')]
+ [('CAST(1 AS TINYINT)', 'tinyint')]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39551: [SPARK-42047][SPARK-41900][CONNECT][PYTHON] Literal should support Numpy datatypes
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39551:
URL: https://github.com/apache/spark/pull/39551#issuecomment-1381479340
cc @xinrong-meng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org