You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/02 17:17:21 UTC
[GitHub] [daffodil-vscode] scholarsmate opened a new pull request, #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
scholarsmate opened a new pull request, #363:
URL: https://github.com/apache/daffodil-vscode/pull/363
closes #360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate merged pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
scholarsmate merged PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1038450471
##########
package.json:
##########
@@ -1,7 +1,7 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
Review Comment:
Yes we should! I'll get to those next week. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1038450471
##########
package.json:
##########
@@ -1,7 +1,7 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
Review Comment:
Yes we should! I'll get to those next week or over the weekend. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1043536805
##########
package.json:
##########
@@ -1,8 +1,8 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
- "description": "VS Code extension for Apache Daffodil DFDL schema debugging",
- "version": "1.2.0-SNAPSHOT",
+ "displayName": "Apache Daffodil™ Extension for Visual Studio Code",
+ "description": "Apache Daffodil™ Extension for Visual Studio Code providing DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data editor",
+ "version": "1.3.0-SNAPSHOT",
Review Comment:
I would prefer we bump the snapshot version in a separate commit. Also, this branch should have been pushed to a fork and not directly to the apache/daffodil-vscode repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1038450471
##########
package.json:
##########
@@ -1,7 +1,7 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
Review Comment:
Yes we should! I'll get to those next week or over the weekend. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1038468268
##########
package.json:
##########
@@ -1,7 +1,7 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
Review Comment:
I think I found and replaced all instances of the old name with the new (according to `git grep`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1043561077
##########
package.json:
##########
@@ -1,8 +1,8 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
- "description": "VS Code extension for Apache Daffodil DFDL schema debugging",
- "version": "1.2.0-SNAPSHOT",
+ "displayName": "Apache Daffodil™ Extension for Visual Studio Code",
+ "description": "Apache Daffodil™ Extension for Visual Studio Code providing DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data editor",
+ "version": "1.3.0-SNAPSHOT",
Review Comment:
A little trick to ensure we don't accidentally push to this remote is to do something like this (assuming the name of your remote that points to apache/daffodil-vscode is `asf`):
```
git config remote.asf.pushurl "push to apache/daffodil-vscode disabled"
```
This is a bit of a hack, but it makes it so if you ever do try to push to the asf remote you'll get an error about not the push remote not being a repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1043548934
##########
package.json:
##########
@@ -1,8 +1,8 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
- "description": "VS Code extension for Apache Daffodil DFDL schema debugging",
- "version": "1.2.0-SNAPSHOT",
+ "displayName": "Apache Daffodil™ Extension for Visual Studio Code",
+ "description": "Apache Daffodil™ Extension for Visual Studio Code providing DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data editor",
+ "version": "1.3.0-SNAPSHOT",
Review Comment:
Okay, I'll roll the SNAPSHOT version out of here and get that in a different PR on my fork. Noted about doing PRs in forks and not directly on the upstream repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #363: Change name to "Apache Daffodil™ Extension for Visual Studio Code"
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #363:
URL: https://github.com/apache/daffodil-vscode/pull/363#discussion_r1038360557
##########
package.json:
##########
@@ -1,7 +1,7 @@
{
"name": "apache-daffodil-vscode",
- "displayName": "Apache Daffodil VS Code Extension",
Review Comment:
`Apache Daffodil VS Code Extension` also shows up in a few other files:
* LICENSE
* NOTICE
* README.md
* build/package/NOLICENSE
* build/package/NONOTICE
* package.json
Should we update it in those files too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org