You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/01 14:27:58 UTC

[GitHub] [superset] michael-s-molina commented on a diff in pull request #20572: [WIP] feat: Renders Explore in SPA

michael-s-molina commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r912013234


##########
superset-frontend/src/explore/exploreUtils/index.js:
##########
@@ -87,7 +87,7 @@ export function getURIDirectory(endpointType = 'base') {
   ) {
     return '/superset/explore_json/';
   }
-  return '/superset/explore/';
+  return '/explore/';

Review Comment:
   You're right. I added a workaround to fix it and a `TODO` to remove the workaround with the next PR.
   
   ```
   // TODO: This will be removed in the next PR that will change the logic to save a slice
   url = url.replace('/explore', '/superset/explore');
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org