You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/08 15:26:21 UTC
[GitHub] [rocketmq] RongtongJin opened a new pull request, #4578: The code of branch 5.0.0-beta merge into develop branch
RongtongJin opened a new pull request, #4578:
URL: https://github.com/apache/rocketmq/pull/4578
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Recently we released 4.9.4 LTS version. The LTS version is the long-term support version. Subsequent bug fixes will be backported to this version from the trunk in a timely manner. We have created a 4.9.x branch, which is used for the long-term repair of bugs in RocketMQ 4.9.x.
This pull request will now merge the code in RocketMQ 5.0 into the develop branch. All the new features of RocketMQ 5.x will be in the develop branch later. Let’s look forward to the first version of RocketMQ 5.0.
## Brief changelog
All the changes in [5.0.0-beta](https://github.com/apache/rocketmq/tree/5.0.0-beta) branch
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #4578: The code of 5.0.0-beta merge into develop branch
Posted by GitBox <gi...@apache.org>.
duhenglucky merged PR #4578:
URL: https://github.com/apache/rocketmq/pull/4578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4578: The code of 5.0.0-beta merge into develop branch
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4578:
URL: https://github.com/apache/rocketmq/pull/4578#issuecomment-1179356942
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4578?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4578](https://codecov.io/gh/apache/rocketmq/pull/4578?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ef151d) into [develop](https://codecov.io/gh/apache/rocketmq/commit/35ce9ad4d52e739b5a0a3eebceba3383632d88af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (35ce9ad) will **decrease** coverage by `4.77%`.
> The diff coverage is `29.76%`.
```diff
@@ Coverage Diff @@
## develop #4578 +/- ##
=============================================
- Coverage 48.25% 43.48% -4.78%
- Complexity 5143 6218 +1075
=============================================
Files 649 817 +168
Lines 43037 57672 +14635
Branches 5629 7877 +2248
=============================================
+ Hits 20766 25076 +4310
- Misses 19768 29351 +9583
- Partials 2503 3245 +742
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `49.17% <ø> (+3.03%)` | :arrow_up: |
| [...ache/rocketmq/broker/client/ConsumerGroupInfo.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L0NvbnN1bWVyR3JvdXBJbmZvLmphdmE=) | `55.85% <0.00%> (+6.76%)` | :arrow_up: |
| [...ache/rocketmq/broker/client/net/Broker2Client.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvY2xpZW50L25ldC9Ccm9rZXIyQ2xpZW50LmphdmE=) | `2.48% <0.00%> (ø)` | |
| [...ketmq/broker/dledger/DLedgerRoleChangeHandler.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvZGxlZGdlci9ETGVkZ2VyUm9sZUNoYW5nZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../broker/longpolling/LmqPullRequestHoldService.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvTG1xUHVsbFJlcXVlc3RIb2xkU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/rocketmq/broker/longpolling/ManyPullRequest.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvTWFueVB1bGxSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...cketmq/broker/longpolling/NotificationRequest.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvTm90aWZpY2F0aW9uUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...tmq/broker/longpolling/PullRequestHoldService.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvbG9uZ3BvbGxpbmcvUHVsbFJlcXVlc3RIb2xkU2VydmljZS5qYXZh) | `16.83% <0.00%> (-3.66%)` | :arrow_down: |
| [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <ø> (ø)` | |
| [...etmq/broker/plugin/AbstractPluginMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGx1Z2luL0Fic3RyYWN0UGx1Z2luTWVzc2FnZVN0b3JlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| ... and [471 more](https://codecov.io/gh/apache/rocketmq/pull/4578/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4578?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4578?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [35ce9ad...8ef151d](https://codecov.io/gh/apache/rocketmq/pull/4578?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4578: The code of 5.0.0-beta merge into develop branch
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4578:
URL: https://github.com/apache/rocketmq/pull/4578#issuecomment-1181269537
[](https://coveralls.io/builds/50778778)
Coverage decreased (-4.4%) to 47.604% when pulling **69b74d2456e2dc9a836361a0c8a41cd5535c9b80 on develop-merge-5.0.0** into **35ce9ad4d52e739b5a0a3eebceba3383632d88af on develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org