You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/12/26 21:55:08 UTC
[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat
slawekjaranowski opened a new pull request, #202:
URL: https://github.com/apache/maven-enforcer/pull/202
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat
Posted by GitBox <gi...@apache.org>.
ajarmoniuk commented on PR #202:
URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367811069
> [@ajarmoniuk](https://github.com/ajarmoniuk) - can you check it, looks strange
> I also afraid that IT test - require-release-dependencies check nothing - there is no dependencies in test
also
> In unit test I see:
> [INFO] Running org.apache.maven.plugins.enforcer.TestRequireReleaseDeps
[debug] groupId:artifactId:jar:classifier:version
groupId:artifact:jar:classifier:1.0.0 <--- is not a release dependency
groupId:artifact:jar:classifier:2.0.0 <--- is not a release dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #202:
URL: https://github.com/apache/maven-enforcer/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat
Posted by GitBox <gi...@apache.org>.
ajarmoniuk commented on PR #202:
URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367811899
Can't see them anywhere. I only got a notification about new comments, but there were nowhere to be seen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] ajarmoniuk commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat
Posted by GitBox <gi...@apache.org>.
ajarmoniuk commented on PR #202:
URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367593219
Did you remove your comments from this PR? I can only see them in my email. Are they still valid? @slawekjaranowski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #202:
URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367809795
Which comments? I don't remember to remove something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #202: [MENFORCER-435] Remove not needed maven-dependency-tree and maven-compat
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #202:
URL: https://github.com/apache/maven-enforcer/pull/202#issuecomment-1367813010
It is valid questions.
I added comments on commit ...
https://github.com/apache/maven-enforcer/commit/919fe02a0fe92a055a6e24dff04fb9c7618954f4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org