You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by mm...@apache.org on 2018/02/26 22:41:03 UTC
[bookkeeper] branch master updated: Allow derived implementations
of RackawareEnsemblePlacementPolicy
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new c618d9a Allow derived implementations of RackawareEnsemblePlacementPolicy
c618d9a is described below
commit c618d9a72b4f79cb2162ba7653c934dda8878596
Author: Matteo Merli <mm...@apache.org>
AuthorDate: Mon Feb 26 14:40:54 2018 -0800
Allow derived implementations of RackawareEnsemblePlacementPolicy
Leave public constructor so that it's possible to create a placement policy that derives from RackawareEnsemblePlacementPolicy.
For example, in Pulsar we have an isolation policy that works in conjunction with the rack-aware: https://github.com/apache/incubator-pulsar/blob/ac94698df6c66c4b84faa9f96db71f0019bf955e/pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZkIsolatedBookieEnsemblePlacementPolicy.java#L45
Author: Matteo Merli <mm...@apache.org>
Reviewers: Enrico Olivelli <eo...@gmail.com>, Sijie Guo <si...@apache.org>
This closes #1206 from merlimat/master
---
.../apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java
index 4359e16..def9554 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicy.java
@@ -37,11 +37,11 @@ public class RackawareEnsemblePlacementPolicy extends RackawareEnsemblePlacement
implements ITopologyAwareEnsemblePlacementPolicy<TopologyAwareEnsemblePlacementPolicy.BookieNode> {
RackawareEnsemblePlacementPolicyImpl slave = null;
- RackawareEnsemblePlacementPolicy() {
+ public RackawareEnsemblePlacementPolicy() {
super();
}
- RackawareEnsemblePlacementPolicy(boolean enforceDurability) {
+ public RackawareEnsemblePlacementPolicy(boolean enforceDurability) {
super(enforceDurability);
}
--
To stop receiving notification emails like this one, please contact
mmerli@apache.org.