[GitHub] [flink] zentol commented on a change in pull request #16352: [FLINK-23102][runtime] Accessing FlameGraphs while not being enabled …

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #16352:
URL: https://github.com/apache/flink/pull/16352#discussion_r664319787



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexFlameGraphHandler.java
##########
@@ -54,14 +56,18 @@ public JobVertexFlameGraphHandler(
             Map<String, String> responseHeaders,
             ExecutionGraphCache executionGraphCache,
             Executor executor,
-            JobVertexThreadInfoTracker<JobVertexThreadInfoStats> threadInfoOperatorTracker) {
+            @Nullable
+                    JobVertexThreadInfoTracker<JobVertexThreadInfoStats>
+                            threadInfoOperatorTracker) {
         super(
                 leaderRetriever,
                 timeout,
                 responseHeaders,
                 JobVertexFlameGraphHeaders.getInstance(),
                 executionGraphCache,
                 executor);
+        // If threadInfoOperatorTracker is not initialized, it means the flame graph is disabled and
+        // returns an empty flame graph when requested

Review comment:
       ```suggestion
           // If threadInfoOperatorTracker is not initialized, it means the flame graph is disabled and
           // we should return an empty flame graph when requested
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org