You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/06/11 14:17:42 UTC
[jira] [Created] (LUCENE-4130) CompoundFileDirectory.listAll is
broken
Robert Muir created LUCENE-4130:
-----------------------------------
Summary: CompoundFileDirectory.listAll is broken
Key: LUCENE-4130
URL: https://issues.apache.org/jira/browse/LUCENE-4130
Project: Lucene - Java
Issue Type: Bug
Affects Versions: 4.0
Reporter: Robert Muir
The files returned by listAll are not actually the files in the CFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4130) CompoundFileDirectory.listAll is
broken
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4130:
--------------------------------
Attachment: LUCENE-4130.patch
The problem is the ad-hoc substring'ing done in listAll: it doesnt work with norms/dv because they use CFS filenames with segment suffixes.
Instead of this substring, i added a IndexFileNames.parseSegmentName that is just like stripSegmentName, except returns the other part.
> CompoundFileDirectory.listAll is broken
> ---------------------------------------
>
> Key: LUCENE-4130
> URL: https://issues.apache.org/jira/browse/LUCENE-4130
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-4130.patch, LUCENE-4130_test.patch
>
>
> The files returned by listAll are not actually the files in the CFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4130) CompoundFileDirectory.listAll is
broken
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4130:
--------------------------------
Attachment: LUCENE-4130.patch
cleaned-up patch, removing the duplicate code of 'find segment boundary/indexOf' between stripSegmentName and parseSegmentName (so its not easy to break the relationship between the two), and returning empty string from parse (which is more correct, also means CFS is transparent for files without a segment prefix). also removed the TODO from TestAllFilesHaveCodecHeader to recurse into CFS.
I think this is ready to commit
> CompoundFileDirectory.listAll is broken
> ---------------------------------------
>
> Key: LUCENE-4130
> URL: https://issues.apache.org/jira/browse/LUCENE-4130
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-4130.patch, LUCENE-4130.patch, LUCENE-4130_test.patch
>
>
> The files returned by listAll are not actually the files in the CFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4130) CompoundFileDirectory.listAll is
broken
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292918#comment-13292918 ]
Michael McCandless commented on LUCENE-4130:
--------------------------------------------
+1, sneaky.
> CompoundFileDirectory.listAll is broken
> ---------------------------------------
>
> Key: LUCENE-4130
> URL: https://issues.apache.org/jira/browse/LUCENE-4130
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-4130.patch, LUCENE-4130_test.patch
>
>
> The files returned by listAll are not actually the files in the CFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4130) CompoundFileDirectory.listAll is
broken
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4130:
--------------------------------
Attachment: LUCENE-4130_test.patch
test case
> CompoundFileDirectory.listAll is broken
> ---------------------------------------
>
> Key: LUCENE-4130
> URL: https://issues.apache.org/jira/browse/LUCENE-4130
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-4130_test.patch
>
>
> The files returned by listAll are not actually the files in the CFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4130) CompoundFileDirectory.listAll is
broken
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-4130.
---------------------------------
Resolution: Fixed
Fix Version/s: 5.0
4.0
> CompoundFileDirectory.listAll is broken
> ---------------------------------------
>
> Key: LUCENE-4130
> URL: https://issues.apache.org/jira/browse/LUCENE-4130
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Robert Muir
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4130.patch, LUCENE-4130.patch, LUCENE-4130_test.patch
>
>
> The files returned by listAll are not actually the files in the CFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org