[GitHub] [iceberg] jackye1995 commented on a change in pull request #3078: fix: JdbcCatalog jdbc.user is overwrite by user property

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #3078:
URL: https://github.com/apache/iceberg/pull/3078#discussion_r712456970



##########
File path: core/src/main/java/org/apache/iceberg/util/PropertyUtil.java
##########
@@ -70,4 +71,16 @@ public static String propertyAsString(Map<String, String> properties,
     }
     return defaultValue;
   }
+
+  public static Properties filterAndRemovePrefix(Map<String, String> properties,

Review comment:
       @kbendick I know you suggested the refactoring, but it's unclear to me how this util method can be used by others because of the return type `Properties`. I personally think `JdbcUtil` is a better place to put this, or making it a private method inside `JdbcCatalog` is also good enough. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org