You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "Yohahaha (via GitHub)" <gi...@apache.org> on 2024/08/08 08:36:42 UTC

[I] [VL] Support split_part [incubator-gluten]

Yohahaha opened a new issue, #6758:
URL: https://github.com/apache/incubator-gluten/issues/6758

   ### Description
   
   In Spark, split_part is element_at(StringSplitSQL) actually.
   
   ![image](https://github.com/user-attachments/assets/49a80fdf-0c10-48e9-ab8f-5a840e7d3baa)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] Support split_part [incubator-gluten]

Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on issue #6758:
URL: https://github.com/apache/incubator-gluten/issues/6758#issuecomment-2276947833

   does velox support?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] Support split_part [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on issue #6758:
URL: https://github.com/apache/incubator-gluten/issues/6758#issuecomment-2277031995

   @Yohahaha @FelixYBW, Velox has a similar function also called `split_part` in prestosql folder. A long time ago, we noted this function has some difference from Spark's. So we put it into black list to avoid using that Velox function.
   
   @Yohahaha, would you like to implement Spark's `split_velox` in Velox? Maybe, you can do that based on presto's implementation. And in Gluten, we may need to revert Spark's runtime replacement, i.e., use `split_part` for `element_at(StringSplitSQL)`, then offloading to Velox's `split_part`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [I] [VL] Support split_part [incubator-gluten]

Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha commented on issue #6758:
URL: https://github.com/apache/incubator-gluten/issues/6758#issuecomment-2277143125

   I'm working on support it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org