You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/05/26 23:01:32 UTC

Review Request 34681: [WinTP2] SQL SERVER DROP DB script broken

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34681/
-----------------------------------------------------------

Review request for Ambari, Florian Barca and Jayush Luniya.


Bugs: AMBARI-11397
    https://issues.apache.org/jira/browse/AMBARI-11397


Repository: ambari


Description
-------

[WinTP2] SQL SERVER DROP DB script broken


Diffs
-----

  ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql d57790c 

Diff: https://reviews.apache.org/r/34681/diff/


Testing
-------

Tested manually!
CREATE/DROP DB success!


Thanks,

Artem Baranchuk


Re: Review Request 34681: [WinTP2] SQL SERVER DROP DB script broken

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34681/#review85293
-----------------------------------------------------------

Ship it!


Ship It!

- Florian Barca


On May 26, 2015, 9:01 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34681/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 9:01 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11397
>     https://issues.apache.org/jira/browse/AMBARI-11397
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] SQL SERVER DROP DB script broken
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql d57790c 
> 
> Diff: https://reviews.apache.org/r/34681/diff/
> 
> 
> Testing
> -------
> 
> Tested manually!
> CREATE/DROP DB success!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Re: Review Request 34681: [WinTP2] SQL SERVER DROP DB script broken

Posted by Jayush Luniya <jl...@hortonworks.com>.

> On May 27, 2015, 12:30 a.m., Jayush Luniya wrote:
> > Ship It!

Good work Artem!


- Jayush


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34681/#review85301
-----------------------------------------------------------


On May 26, 2015, 9:01 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34681/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 9:01 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11397
>     https://issues.apache.org/jira/browse/AMBARI-11397
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] SQL SERVER DROP DB script broken
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql d57790c 
> 
> Diff: https://reviews.apache.org/r/34681/diff/
> 
> 
> Testing
> -------
> 
> Tested manually!
> CREATE/DROP DB success!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Re: Review Request 34681: [WinTP2] SQL SERVER DROP DB script broken

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34681/#review85301
-----------------------------------------------------------

Ship it!


Ship It!

- Jayush Luniya


On May 26, 2015, 9:01 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34681/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 9:01 p.m.)
> 
> 
> Review request for Ambari, Florian Barca and Jayush Luniya.
> 
> 
> Bugs: AMBARI-11397
>     https://issues.apache.org/jira/browse/AMBARI-11397
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> [WinTP2] SQL SERVER DROP DB script broken
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql d57790c 
> 
> Diff: https://reviews.apache.org/r/34681/diff/
> 
> 
> Testing
> -------
> 
> Tested manually!
> CREATE/DROP DB success!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>