[jira] Commented: (OFBIZ-3647) Create dataResource from content

["Scott Gray (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854036#action_12854036 ] 

Scott Gray commented on OFBIZ-3647:
-----------------------------------

Hi Nicolas,

Thanks for the patch, here is my review:
# createDataResourceAndGiveType has the following problems:
## It is unnecessary, I can't see any reason why you have switched from using the event that was already there
## The description is wrong
## I don't like using the service response code to return values, this is what events are for
## In the implementation there is no need to do an entity-one because createDataResource returns the GenericValue
# createDataResourceAndAssocToContent
## the "template" service attribute should be a boolean or at the very least a char or Character and why not make the name more verbose like useTemplateDataResourceId?
## please correct the indentation of the if-compare + else elements
## use the updateContent service, you should almost never persist an entity directly

> Create dataResource from content
> --------------------------------
>
>                 Key: OFBIZ-3647
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3647
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: content
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>            Assignee: Scott Gray
>            Priority: Minor
>         Attachments: content.patch
>
>
> When you create a content, you need create a data resource and return to content for create association.
> If a content don't have a dataResource, I change buton : GoToDataResource by Create a DataResource. When this lastest is created, she automaticly associate to the content and retour to EditContent screen

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.