You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/08 12:23:43 UTC

[GitHub] [arrow] nevi-me commented on pull request #8346: ARROW-10164: [Rust] Add support for DictionaryArray to cast kernel

nevi-me commented on pull request #8346:
URL: https://github.com/apache/arrow/pull/8346#issuecomment-705532225


   > 🤔 so the 'pretty-print' feature is not enabled by default for arrow and thus I can't use it in the tests. I put in a hack (copy/paste of the pretty printing) in [9f8b9ba](https://github.com/apache/arrow/commit/9f8b9ba11e9523a19ffc6449ac7a3b915b933ef7) but I am not super happy with that.
   > 
   > @nevi-me do you by any chance have any other suggestions?
   
   Apologies for the delay @alamb. I remember when I started working on Arrow, stringy comparisons were discouraged at the time because you could have arrays that end up having the same string representation, but have data differences which might not get caught.
   This is also important for integration tests.
   
   I'm on the fence, you could enable that assertion only on the `pretty` feature?
   
   Perhaps other commiters will have a differing opinion (@sunchao @jorgecarleitao @paddyhoran @andygrove).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org