[GitHub] [beam] tvalentyn commented on a diff in pull request #23365: Python SpannerIO Fixes

[GitBox <gi...@apache.org>]

tvalentyn commented on code in PR #23365:
URL: https://github.com/apache/beam/pull/23365#discussion_r982709745


##########
sdks/python/setup.py:
##########
@@ -289,7 +289,8 @@ def get_portability_package_data():
             'google-cloud-bigquery-storage>=2.6.3,<2.14',
             'google-cloud-core>=0.28.1,<3',
             'google-cloud-bigtable>=0.31.1,<2',
-            'google-cloud-spanner>=1.13.0,<2',
+            # google-cloud-spanner 2.x causes dependency parsing backoff
+            'google-cloud-spanner>=1.13.0,!=2,<=3.21.0',

Review Comment:
   1. We shouldn't use <= in the upper bound, it precludes us from asking someone to issue a patch release that could still be picked up by the constraints.
   So we can use `<3.22.0` or `<4`. 
   
   2. I think this is server-side dependency only, so using `<4` should be safe as we do with other GCP dependencies at this time. We'll decide soon whether we want to cap upper bounds for all IO.
   
   3. Can you please run PostCommit integration tests with `google-cloud-spanner>=3.0.0` requirement if you haven't ? Unless we specify that requirement, postcommit tests will not pick up the new dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org