[GitHub] [spark] hvanhovell commented on a diff in pull request #40228: [SPARK-41874][CONNECT][PYTHON] Support SameSemantics in Spark Connect

["hvanhovell (via GitHub)" <gi...@apache.org>]

hvanhovell commented on code in PR #40228:
URL: https://github.com/apache/spark/pull/40228#discussion_r1121044824


##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -2724,7 +2724,7 @@ class Dataset[T] private[sql] (
   }
 
   def sameSemantics(other: Dataset[T]): Boolean = {

Review Comment:
   I think the hash argument still stands. However I think this is also a matter of setting the right expectations here, and to update the docs accordingly. 
   
   @WeichenXu123 it would be good to understand your usecase.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org