You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/16 08:28:49 UTC

[GitHub] [dubbo] kylixs opened a new pull request #8824: [3.0] Refactor application/module deploy processing and events

kylixs opened a new pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824


   ## What is the purpose of the change
    * Refactor application/module deploy processing and events,  more clearer state.
    * Split `DubboShutdownHook` and `ShutdownHookCallback`, adjust call chains.
    * Remove `DubboBootstrap` from `dubbo-config-spring` 
    * Improve `SpringExtensionInjector` initialization
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on a change in pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

zrlw commented on a change in pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#discussion_r710014603



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/DubboShutdownHook.java
##########
@@ -81,7 +85,11 @@ public void register() {
      */
     public void unregister() {
         if (registered.compareAndSet(true, false)) {
-            Runtime.getRuntime().removeShutdownHook(this);
+            try {
+                Runtime.getRuntime().removeShutdownHook(this);

Review comment:
       ShutdownHookCallbacks.callback() will be called at Runtime.getRuntime().removeShutdownHook(this):
   ```
   ##[error]Exception in thread "DubboShutdownHook" java.lang.RuntimeException: java.lang.IllegalStateException: Shutdown in progress
    	at org.apache.dubbo.common.function.ThrowableAction.execute(ThrowableAction.java:48)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.lambda$callback$0(ShutdownHookCallbacks.java:72)
    	at java.lang.Iterable.forEach(Iterable.java:75)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.callback(ShutdownHookCallbacks.java:72)
    	at org.apache.dubbo.config.DubboShutdownHook.callback(DubboShutdownHook.java:89)
   ```
   we might add try-catch in ShutdownHookCallbacks callback() method like this, otherwise the callbacks in getCallbacks() after the callback which throw the exception will lost running opptunity:
   ```
   ShutdownHookCallbacks.java:
       private static final Logger logger = LoggerFactory.getLogger(ShutdownHookCallbacks.class);
       public void callback() {
           getCallbacks().forEach(callback -> {
               try {
                   execute(callback::callback);
               } catch (Exception e) {
                   logger.warn("callback exception.", e);
               }
           });
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89ac8a2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.02%`.
   > The diff coverage is `74.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.76%   -0.03%     
   - Complexity      314      315       +1     
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49097     +199     
     Branches       7331     7352      +21     
   ============================================
   + Hits          31195    31309     +114     
   - Misses        14284    14368      +84     
   - Partials       3419     3420       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [100 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...89ac8a2](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab63644) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bcdd8871f2658a01aa04579f8577e8c854432ad6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcdd887) will **decrease** coverage by `0.11%`.
   > The diff coverage is `73.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.68%   -0.12%     
   + Complexity      315      312       -3     
   ============================================
     Files          1161     1169       +8     
     Lines         48983    49196     +213     
     Branches       7334     7359      +25     
   ============================================
   + Hits          31248    31329      +81     
   - Misses        14315    14434     +119     
   - Partials       3420     3433      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/common/bytecode/Wrapper.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvV3JhcHBlci5qYXZh) | `82.58% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | ... and [128 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bcdd887...ab63644](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0fe792) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.22%`.
   > The diff coverage is `73.39%`.
   
   > :exclamation: Current head a0fe792 differs from pull request most recent head 8cb7a05. Consider uploading reports for the commit 8cb7a05 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.56%   -0.23%     
   + Complexity      314      313       -1     
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49069     +171     
     Branches       7331     7324       -7     
   ============================================
   - Hits          31195    31193       -2     
   - Misses        14284    14446     +162     
   - Partials       3419     3430      +11     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [136 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...8cb7a05](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a0fe792) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.17%`.
   > The diff coverage is `73.60%`.
   
   > :exclamation: Current head a0fe792 differs from pull request most recent head 8cb7a05. Consider uploading reports for the commit 8cb7a05 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.62%   -0.18%     
   + Complexity      314      313       -1     
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49107     +209     
     Branches       7331     7353      +22     
   ============================================
   + Hits          31195    31243      +48     
   - Misses        14284    14439     +155     
   - Partials       3419     3425       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [111 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...8cb7a05](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb9f9ec) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.21%`.
   > The diff coverage is `78.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.58%   -0.22%     
     Complexity      314      314              
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49053     +155     
     Branches       7331     7323       -8     
   ============================================
   - Hits          31195    31189       -6     
   - Misses        14284    14437     +153     
   - Partials       3419     3427       +8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [132 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...eb9f9ec](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab63644) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bcdd8871f2658a01aa04579f8577e8c854432ad6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcdd887) will **decrease** coverage by `0.02%`.
   > The diff coverage is `73.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.76%   -0.03%     
   + Complexity      315      314       -1     
   ============================================
     Files          1161     1169       +8     
     Lines         48983    49196     +213     
     Branches       7334     7359      +25     
   ============================================
   + Hits          31248    31371     +123     
   - Misses        14315    14399      +84     
   - Partials       3420     3426       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/common/bytecode/Wrapper.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvV3JhcHBlci5qYXZh) | `82.58% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | ... and [117 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bcdd887...ab63644](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on a change in pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

zrlw commented on a change in pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#discussion_r710014603



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/DubboShutdownHook.java
##########
@@ -81,7 +85,11 @@ public void register() {
      */
     public void unregister() {
         if (registered.compareAndSet(true, false)) {
-            Runtime.getRuntime().removeShutdownHook(this);
+            try {
+                Runtime.getRuntime().removeShutdownHook(this);

Review comment:
       ShutdownHookCallbacks.callback() will be called:
   ```
   ##[error]Exception in thread "DubboShutdownHook" java.lang.RuntimeException: java.lang.IllegalStateException: Shutdown in progress
    	at org.apache.dubbo.common.function.ThrowableAction.execute(ThrowableAction.java:48)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.lambda$callback$0(ShutdownHookCallbacks.java:72)
    	at java.lang.Iterable.forEach(Iterable.java:75)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.callback(ShutdownHookCallbacks.java:72)
    	at org.apache.dubbo.config.DubboShutdownHook.callback(DubboShutdownHook.java:89)
   ```
   you'd better add try-catch in ShutdownHookCallbacks callback() method like this, it will catch all callback exceptions including DubboShutdownHook unregister exception :
   ```
   ShutdownHookCallbacks.java:
       private static final Logger logger = LoggerFactory.getLogger(ShutdownHookCallbacks.class);
       public void callback() {
           getCallbacks().forEach(callback -> {
               try {
                   execute(callback::callback);
               } catch (Exception e) {
                   logger.warn("callback exception.", e);
               }
           });
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on a change in pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

zrlw commented on a change in pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#discussion_r710014603



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/DubboShutdownHook.java
##########
@@ -81,7 +85,11 @@ public void register() {
      */
     public void unregister() {
         if (registered.compareAndSet(true, false)) {
-            Runtime.getRuntime().removeShutdownHook(this);
+            try {
+                Runtime.getRuntime().removeShutdownHook(this);

Review comment:
       ShutdownHookCallbacks.callback() will be called at Runtime.getRuntime().removeShutdownHook(this):
   ```
   ##[error]Exception in thread "DubboShutdownHook" java.lang.RuntimeException: java.lang.IllegalStateException: Shutdown in progress
    	at org.apache.dubbo.common.function.ThrowableAction.execute(ThrowableAction.java:48)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.lambda$callback$0(ShutdownHookCallbacks.java:72)
    	at java.lang.Iterable.forEach(Iterable.java:75)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.callback(ShutdownHookCallbacks.java:72)
    	at org.apache.dubbo.config.DubboShutdownHook.callback(DubboShutdownHook.java:89)
   ```
   we might add try-catch in ShutdownHookCallbacks callback() method like this, otherwise the callbacks in getCallbacks() after the callback which throw the exception will lost running opptunity:
   ```
       private static final Logger logger = LoggerFactory.getLogger(ShutdownHookCallbacks.class);
       public void callback() {
           getCallbacks().forEach(callback -> {
               try {
                   execute(callback::callback);
               } catch (Exception e) {
                   logger.warn("callback exception.", e);
               }
           });
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab63644) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bcdd8871f2658a01aa04579f8577e8c854432ad6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcdd887) will **decrease** coverage by `0.03%`.
   > The diff coverage is `73.75%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.75%   -0.04%     
   + Complexity      315      314       -1     
   ============================================
     Files          1161     1169       +8     
     Lines         48983    49196     +213     
     Branches       7334     7359      +25     
   ============================================
   + Hits          31248    31367     +119     
   - Misses        14315    14402      +87     
   - Partials       3420     3427       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/common/bytecode/Wrapper.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvV3JhcHBlci5qYXZh) | `82.58% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | ... and [117 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bcdd887...ab63644](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6dd18bf) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.22%`.
   > The diff coverage is `77.72%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.56%   -0.23%     
     Complexity      314      314              
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49081     +183     
     Branches       7331     7327       -4     
   ============================================
   + Hits          31195    31199       +4     
   - Misses        14284    14454     +170     
   - Partials       3419     3428       +9     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [120 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...6dd18bf](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89ac8a2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.17%`.
   > The diff coverage is `73.90%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.62%   -0.18%     
     Complexity      314      314              
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49059     +161     
     Branches       7331     7323       -8     
   ============================================
   + Hits          31195    31212      +17     
   - Misses        14284    14415     +131     
   - Partials       3419     3432      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [132 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...89ac8a2](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb9f9ec) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.11%`.
   > The diff coverage is `78.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.68%   -0.12%     
     Complexity      314      314              
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49091     +193     
     Branches       7331     7352      +21     
   ============================================
   + Hits          31195    31262      +67     
   - Misses        14284    14406     +122     
   - Partials       3419     3423       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [108 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...eb9f9ec](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab63644) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bcdd8871f2658a01aa04579f8577e8c854432ad6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bcdd887) will **decrease** coverage by `0.21%`.
   > The diff coverage is `73.54%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.57%   -0.22%     
   + Complexity      315      312       -3     
   ============================================
     Files          1161     1169       +8     
     Lines         48983    49158     +175     
     Branches       7334     7330       -4     
   ============================================
   + Hits          31248    31252       +4     
   - Misses        14315    14472     +157     
   - Partials       3420     3434      +14     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/dubbo/common/bytecode/Wrapper.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvV3JhcHBlci5qYXZh) | `82.58% <ø> (ø)` | |
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | ... and [150 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bcdd887...ab63644](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] zrlw commented on a change in pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

zrlw commented on a change in pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#discussion_r710014603



##########
File path: dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/DubboShutdownHook.java
##########
@@ -81,7 +85,11 @@ public void register() {
      */
     public void unregister() {
         if (registered.compareAndSet(true, false)) {
-            Runtime.getRuntime().removeShutdownHook(this);
+            try {
+                Runtime.getRuntime().removeShutdownHook(this);

Review comment:
       ShutdownHookCallbacks.callback() will be called:
   ```
   ##[error]Exception in thread "DubboShutdownHook" java.lang.RuntimeException: java.lang.IllegalStateException: Shutdown in progress
    	at org.apache.dubbo.common.function.ThrowableAction.execute(ThrowableAction.java:48)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.lambda$callback$0(ShutdownHookCallbacks.java:72)
    	at java.lang.Iterable.forEach(Iterable.java:75)
    	at org.apache.dubbo.common.lang.ShutdownHookCallbacks.callback(ShutdownHookCallbacks.java:72)
    	at org.apache.dubbo.config.DubboShutdownHook.callback(DubboShutdownHook.java:89)
   ```
   you'd better add try-catch in ShutdownHookCallbacks callback() method like this, it will catch all callback exceptions including DubboShutdownHook unregister exception :
   ```
   ShutdownHookCallbacks.java:
       private static final Logger logger = LoggerFactory.getLogger(ShutdownHookCallbacks.class);
       public void callback() {
           getCallbacks().forEach(callback -> {
               try {
                   execute(callback::callback);
               } catch (Exception e) {
                   logger.warn("callback exception.", e);
               }
           });
       }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

AlbumenJ merged pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #8824: [3.0] Refactor application/module deploy processing and events

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #8824:
URL: https://github.com/apache/dubbo/pull/8824#issuecomment-920730912


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#8824](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (89ac8a2) into [3.0](https://codecov.io/gh/apache/dubbo/commit/a9aba45a001aea45049e9607f93ff9b0d607c6a6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9aba45) will **decrease** coverage by `0.12%`.
   > The diff coverage is `74.12%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/8824/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #8824      +/-   ##
   ============================================
   - Coverage     63.79%   63.67%   -0.13%     
     Complexity      314      314              
   ============================================
     Files          1160     1168       +8     
     Lines         48898    49097     +199     
     Branches       7331     7352      +21     
   ============================================
   + Hits          31195    31261      +66     
   - Misses        14284    14410     +126     
   - Partials       3419     3426       +7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/dubbo/config/ServiceConfigBase.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZ0Jhc2UuamF2YQ==) | `61.01% <0.00%> (-1.27%)` | :arrow_down: |
   | [...ache/dubbo/config/ConfigScopeModelInitializer.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdTY29wZU1vZGVsSW5pdGlhbGl6ZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...ing/context/DubboBootstrapApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcEFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `0.00% <0.00%> (-61.12%)` | :arrow_down: |
   | [.../DubboBootstrapStartStopListenerSpringAdapter.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0Jvb3RzdHJhcFN0YXJ0U3RvcExpc3RlbmVyU3ByaW5nQWRhcHRlci5qYXZh) | `42.85% <ø> (-57.15%)` | :arrow_down: |
   | [.../annotation/DubboConfigConfigurationRegistrar.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQ29uZmlndXJhdGlvblJlZ2lzdHJhci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...pring/context/event/DubboBootstrapStatedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0YXRlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...pring/context/event/DubboBootstrapStopedEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0Jvb3RzdHJhcFN0b3BlZEV2ZW50LmphdmE=) | `0.00% <ø> (-66.67%)` | :arrow_down: |
   | [...fig/spring/context/event/DubboConfigInitEvent.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9ldmVudC9EdWJib0NvbmZpZ0luaXRFdmVudC5qYXZh) | `66.66% <ø> (ø)` | |
   | [.../dubbo/metadata/report/MetadataReportInstance.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tbWV0YWRhdGEvZHViYm8tbWV0YWRhdGEtYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9yZXBvcnQvTWV0YWRhdGFSZXBvcnRJbnN0YW5jZS5qYXZh) | `84.84% <ø> (-0.45%)` | :arrow_down: |
   | [...e/dubbo/qos/probe/impl/DeployerReadinessProbe.java](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb2JlL2ltcGwvRGVwbG95ZXJSZWFkaW5lc3NQcm9iZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [108 more](https://codecov.io/gh/apache/dubbo/pull/8824/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a9aba45...89ac8a2](https://codecov.io/gh/apache/dubbo/pull/8824?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org