You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/18 17:23:46 UTC
[GitHub] [airflow] pingzh opened a new issue, #23059: Presto hook is broken in the latest provider release (2.2.0)
pingzh opened a new issue, #23059:
URL: https://github.com/apache/airflow/issues/23059
### Apache Airflow version
2.2.5 (latest released)
### What happened
The latest presto provider release https://pypi.org/project/apache-airflow-providers-presto/ is broken due to:
```
File "/usr/local/lib/python3.8/site-packages/airflow/providers/presto/hooks/presto.py", line 117, in get_conn
http_headers = {"X-Presto-Client-Info": generate_presto_client_info()}
File "/usr/local/lib/python3.8/site-packages/airflow/providers/presto/hooks/presto.py", line 56, in generate_presto_client_info
'try_number': context_var['try_number'],
KeyError: 'try_number'
```
### What you think should happen instead
This is due to the latest airflow release 2.2.5 does not include this PR:
https://github.com/apache/airflow/pull/22297/
### How to reproduce
_No response_
### Operating System
Mac
### Versions of Apache Airflow Providers
https://pypi.org/project/apache-airflow-providers-presto/
version: 2.2.0
### Deployment
Other
### Deployment details
local
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #23059: Presto hook is broken in the latest provider release (2.2.0)
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #23059: Presto hook is broken in the latest provider release (2.2.0)
URL: https://github.com/apache/airflow/issues/23059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #23059: Presto hook is broken in the latest provider release (2.2.0)
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #23059:
URL: https://github.com/apache/airflow/issues/23059#issuecomment-1102103559
> @eladkal good point. I remember there is a CI check for the compatibility. not sure why it did not catch it
>
> @eladkal could you please take a look? #23061
The check is not 100% - it only checks that imports are not broken. We are adding more "back-compatibility" checks as pre-commits but I think we are just learning on the kinds of things that should be taken into account.
Here is the currenet check and we should add try_number check there too: https://github.com/apache/airflow/blob/main/scripts/ci/pre_commit/pre_commit_check_2_1_compatibility.py
In short what needs to happen - we need to formalize the provider's interface a bit more than we did so far in the future and make sure that any changes to "contract" in Airflow are "flagged" and any changes are protected against those changes. For now it is more retro-active but before we split off providers from the core repositry (I think this is something we are going to discuss during the next months) we will have to take the learnings from such cases and formalize it.
The May 21 bumping min-compatibility to 2.2. will be a good opportunity to do it.
Those cases are a good learning grounds for the future more "robust" solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #23059: Presto hook is broken in the latest provider release (2.2.0)
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #23059:
URL: https://github.com/apache/airflow/issues/23059#issuecomment-1101605827
Providers must be compatible with Airflow>=2.1 so regardless if https://github.com/apache/airflow/pull/22297 was released in 2.2.5 or not... that is not enough.
We need to make the provider compatible with 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on issue #23059: Presto hook is broken in the latest provider release (2.2.0)
Posted by GitBox <gi...@apache.org>.
pingzh commented on issue #23059:
URL: https://github.com/apache/airflow/issues/23059#issuecomment-1101585607
cc @ephraimbuddy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] pingzh commented on issue #23059: Presto hook is broken in the latest provider release (2.2.0)
Posted by GitBox <gi...@apache.org>.
pingzh commented on issue #23059:
URL: https://github.com/apache/airflow/issues/23059#issuecomment-1101779836
@eladkal good point. I remember there is a CI check for the compatibility. not sure why it did not catch it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org