You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/21 12:05:55 UTC

[GitHub] [spark] dominikgehl commented on a change in pull request #33461: [SPARK-36243][PYTHON][DOCS] Additional unit tests for pyspark tableExists

dominikgehl commented on a change in pull request #33461:
URL: https://github.com/apache/spark/pull/33461#discussion_r673912327



##########
File path: python/pyspark/sql/tests/test_catalog.py
##########
@@ -210,17 +210,34 @@ def test_list_columns(self):
 
     def test_table_exists(self):
         # SPARK-36176: testing that table_exists returns correct boolean
+        from pyspark.sql.catalog import Table

Review comment:
       @HyukjinKwon Actually, the last test here currently fails, which is why I added it. The test shows that while a temporary view gets correctly reported in listTables, it doesn't return true using tableExists. Now, I'm not sure if there's someone on the scala side who might have more insights into why this is happening and/or whether the scala documentation is outdated stating that temporary views are ok for tableExists




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org