You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/07 19:54:18 UTC

[GitHub] [airflow] dstandish commented on a diff in pull request #25410: Consolidate to one `schedule` param

dstandish commented on code in PR #25410:
URL: https://github.com/apache/airflow/pull/25410#discussion_r939715083


##########
docs/apache-airflow/templates-ref.rst:
##########
@@ -89,16 +89,11 @@ existing code to use other variables instead.
 Deprecated Variable                     Description
 =====================================   ====================================
 ``{{ execution_date }}``                the execution date (logical date), same as ``dag_run.logical_date``
-``{{ next_execution_date }}``           the next execution date (if available) (`pendulum.DateTime`_)
-                                        if ``{{ execution_date }}`` is ``2018-01-01 00:00:00`` and
-                                        ``schedule_interval`` is ``@weekly``, ``{{ next_execution_date }}``
-                                        will be ``2018-01-08 00:00:00``

Review Comment:
   it was intentional.  firstly, these are all *deprecated*, so folks reading the docs should not be using them anyway.  secondly, by referencing "logical date"  in the definition, we defer to the example in the section of non-deprecated items.
   
   note there is also no example for the also-deprecated value `execution_date`
   
   the example and explanation were confusing anyway so this to me  seem better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org