You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "ASF GitHub Bot (JIRA)" <se...@james.apache.org> on 2018/01/17 08:45:00 UTC
[jira] [Commented] (JAMES-2310) Use LineBasedFrameDecoder instead
of DelimiterBasedFrameDecoder
[ https://issues.apache.org/jira/browse/JAMES-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328492#comment-16328492 ]
ASF GitHub Bot commented on JAMES-2310:
---------------------------------------
Github user chikei commented on the issue:
https://github.com/apache/james-project/pull/98
As the DelimiterBasedFrameDecoder from netty (which LineDelimiterBasedChannelHandlerFactory directly construct) will automatically use line decoder if we use it directly and with CRLF/LF as delimiter, so only IMAP and SMTP will actually gain some performance from this changes.
Therefore I only make change to SwitchableDelimiterBasedFrameDecoder/AllButStartTlsDelimiterChannelHandler in new commit, if you prefer also make LineDelimiterBasedChannelHandlerFactory explicitly use line frame decoder I'll make additional changes.
> Use LineBasedFrameDecoder instead of DelimiterBasedFrameDecoder
> ---------------------------------------------------------------
>
> Key: JAMES-2310
> URL: https://issues.apache.org/jira/browse/JAMES-2310
> Project: James Server
> Issue Type: Improvement
> Components: IMAPServer, SMTPServer
> Affects Versions: 3.0.1
> Reporter: TzeKai Lee
> Priority: Major
>
> The LineBasedFrameDecoder is optimized version of DelimiterBasedFrameDecoder which provide some good performance gain. The DelimiterBasedFrameDecoder already automatically use LineBasedFrameDecoder if we use DelimiterBasedFrameDecoder (_but not subclass_) and with CRLF/LF as delimiter. However in SMTP and IMAP server we have to subclass it, therefore we should directly extend LineBasedFrameDecoder for the performance gain.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org