You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2014/07/10 22:39:49 UTC
Review Request 23401: SENTRY-329: Alter table rename fails when we enable
data objects and privileges syncing via hive meta store
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23401/
-----------------------------------------------------------
Review request for sentry and Sravya Tirukkovalur.
Bugs: SENTRY-329
https://issues.apache.org/jira/browse/SENTRY-329
Repository: sentry
Description
-------
The privilege rename triggered by Metastore plugin for 'alter table .. rename ..' doesn't set grantor_principal. As a result when you use a dbstore that's backed by a non-derby database it fails. Derby currently doesn't enforce non-null constraints for grantor_principal.
This patch is addressing the missing grantor principal. will log a followup ticket to make all essential fields as non-null in the jdo file.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 50507ea
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 40ac881
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java b23f477
Diff: https://reviews.apache.org/r/23401/diff/
Testing
-------
The failure itself doesn't reproduce in unit tests since they user Derby. The new test case verifies that the grantor_principal is set correctly.
Thanks,
Prasad Mujumdar
Re: Review Request 23401: SENTRY-329: Alter table rename fails when we
enable data objects and privileges syncing via hive meta store
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23401/#review47618
-----------------------------------------------------------
Ship it!
Ship It!
- Sravya Tirukkovalur
On July 10, 2014, 8:39 p.m., Prasad Mujumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23401/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 8:39 p.m.)
>
>
> Review request for sentry and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-329
> https://issues.apache.org/jira/browse/SENTRY-329
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The privilege rename triggered by Metastore plugin for 'alter table .. rename ..' doesn't set grantor_principal. As a result when you use a dbstore that's backed by a non-derby database it fails. Derby currently doesn't enforce non-null constraints for grantor_principal.
> This patch is addressing the missing grantor principal. will log a followup ticket to make all essential fields as non-null in the jdo file.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 50507ea
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 40ac881
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java b23f477
>
> Diff: https://reviews.apache.org/r/23401/diff/
>
>
> Testing
> -------
>
> The failure itself doesn't reproduce in unit tests since they user Derby. The new test case verifies that the grantor_principal is set correctly.
>
>
> Thanks,
>
> Prasad Mujumdar
>
>